Skip to content

Commit cea2d19

Browse files
dgibsonsbrivio-rh
authored andcommitted
Makefile: Remove misleading comments on BASE_*FLAGS
I added these comments attempting to describe the difference between BASE_CFLAGS and CFLAGS. However, the description given isn't really accurate, and I'm not even sure the concept I'm trying to describe is coherent. Just remove it. Suggested-by: Stefano Brivio <sbrivio@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
1 parent 5038f92 commit cea2d19

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,11 @@ ifeq ($(shell $(CC) -O2 -dM -E - < /dev/null 2>&1 | grep ' _FORTIFY_SOURCE ' > /
3030
FORTIFY_FLAG := -D_FORTIFY_SOURCE=2
3131
endif
3232

33-
# Mandatory preprocessor flags that won't be overridden with $(CPPFLAGS)
34-
# FIXME: Could some of these be default, rather than required?
3533
BASE_CPPFLAGS := -D_XOPEN_SOURCE=700 -D_GNU_SOURCE $(FORTIFY_FLAG)
3634
BASE_CPPFLAGS += -DPAGE_SIZE=$(shell getconf PAGE_SIZE)
3735
BASE_CPPFLAGS += -DVERSION=\"$(VERSION)\"
3836
BASE_CPPFLAGS += -DDUAL_STACK_SOCKETS=$(DUAL_STACK_SOCKETS)
3937

40-
# Mandatory compiler flags that won't be overridden with $(CFLAGS)
41-
# FIXME: Could some of these be default, rather than required?
4238
BASE_CFLAGS := -std=c11 -pie -fPIE -O2
4339
BASE_CFLAGS += -pedantic -Wall -Wextra -Wno-format-zero-length -Wformat-security
4440

0 commit comments

Comments
 (0)