VS libsai writes objects to ASIC DB when SAI call is not successful

[theasianpianist]

When bulk SAI APIs do not yet have support in sairedis, they will return "SAI_STATUS_NOT_IMPLEMENTED". However, in VS SAI implementation, these un-implemented API calls will still write objects to ASIC_DB, so any tests which check ASIC_DB values will pass even if the SAI API is not supported in sairedis. Vendor SAI does not have this issue, no DB writes occur if the SAI call is not successful.

[kcudnik]

can you give specific example ? is that in sync/async mode ?

[theasianpianist]

can you give specific example ? is that in sync/async mode ?

We saw this in synchronous mode w/ sai_dash_tunnel_api_t. Syslogs had error message

May  1 18:00:32.656634 d404b9324052 ERR #syncd: :- bulkCreate: not implemented SAI_OBJECT_TYPE_DASH_TUNNEL, FIXME
May  1 18:00:32.656644 d404b9324052 WARNING #syncd: :- processBulkOidCreate: bulkCreate api is not implemented or not supported, object_type = SAI_OBJECT_TYPE_DASH_TUNNEL

But the SAI object was still written to ASIC DB.

[kcudnik]

https://github.com/sonic-net/sonic-sairedis/blob/master/syncd/Syncd.cpp#L2522 here, if vendor dont suppot bulkcreate and returns not supported or not implemented, it fallbacks to single oid create on that api, so actually api is executed, only 1 by 1, and db is updated, can you show sairedis.rec on that particular api execution ? whether in recurding it returned SAI_STATUS_SUCCESS?