chore(deps): upgrade

Author: sonofmagic

.changeset/catalog-specifiers-support.md

@@ -0,0 +1,5 @@
+---
+'@icebreakers/monorepo': patch
+---
+
+Handle pnpm `catalog:` version specifiers during `monorepo up` so catalog-managed dependencies are preserved without semver parsing errors.

packages/monorepo/src/commands/upgrade/pkg-json.ts

@@ -3,18 +3,25 @@ import { coerce, gte, minVersion } from 'semver'
 import { name as pkgName, version as pkgVersion } from '../../constants'
 import { scriptsEntries } from './scripts'
 
-function isWorkspace(version?: string) {
-  if (typeof version === 'string') {
-    return version.startsWith('workspace:')
-  }
-  return false
-}
+const NON_OVERRIDABLE_PREFIXES = ['workspace:', 'catalog:']
 
 function parseVersion(input: unknown) {
   if (typeof input !== 'string' || input.trim().length === 0) {
     return null
   }
-  return minVersion(input) ?? coerce(input)
+  try {
+    return minVersion(input) ?? coerce(input)
+  }
+  catch {
+    return null
+  }
+}
+
+function hasNonOverridablePrefix(version?: string) {
+  if (typeof version !== 'string') {
+    return false
+  }
+  return NON_OVERRIDABLE_PREFIXES.some(prefix => version.startsWith(prefix))
 }
 
 function shouldAssignVersion(currentVersion: unknown, nextVersion: string) {
@@ -65,7 +72,7 @@ export function setPkgJson(
     }
 
     const targetVersion = targetDeps[depName]
-    if (isWorkspace(targetVersion)) {
+    if (hasNonOverridablePrefix(targetVersion)) {
       continue
     }
     if (shouldAssignVersion(targetVersion, depVersion)) {
@@ -84,13 +91,13 @@ export function setPkgJson(
     if (depName === pkgName) {
       const nextVersion = `^${pkgVersion}`
       const targetVersion = targetDevDeps[depName]
-      if (!isWorkspace(targetVersion) && shouldAssignVersion(targetVersion, nextVersion)) {
+      if (!hasNonOverridablePrefix(targetVersion) && shouldAssignVersion(targetVersion, nextVersion)) {
         targetDevDeps[depName] = nextVersion
       }
     }
     else {
       const targetVersion = targetDevDeps[depName]
-      if (isWorkspace(targetVersion)) {
+      if (hasNonOverridablePrefix(targetVersion)) {
         continue
       }
       if (shouldAssignVersion(targetVersion, depVersion)) {

packages/monorepo/test/commands/upgrade.pkg-json.coverage.test.ts

@@ -12,6 +12,7 @@ describe('upgrade pkg-json helpers coverage', () => {
         'dep-keep': '^1.0.0',
         'dep-update': '^1.2.0',
         'dep-empty': '',
+        'dep-catalog': '^1.3.0',
       },
       devDependencies: {
         '@icebreakers/monorepo': '^0.0.1',
@@ -26,6 +27,7 @@ describe('upgrade pkg-json helpers coverage', () => {
         'dep-update': '^1.0.0',
         'dep-empty': '  ',
         'dep-workspace': 'workspace:*',
+        'dep-catalog': 'catalog:crossEnv',
       },
       devDependencies: {
         '@icebreakers/monorepo': '^0.2.0',
@@ -49,6 +51,7 @@ describe('upgrade pkg-json helpers coverage', () => {
       'dep-update': '^1.2.0',
       'dep-empty': '',
       'dep-workspace': 'workspace:*',
+      'dep-catalog': 'catalog:crossEnv',
     })
     expect(target.devDependencies?.['dep-dev-update']).toBe('workspace:^2.0.0')
     expect(target.devDependencies?.['dep-dev-stale']).toBe('^2.0.0')