-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testing on Windows with AppVeyor #1331
Conversation
Well, it is nice to have official confirmation that the tweaks I made to get tests passing on AppVeyor didn't break Travis, at least. Meanwhile, if anyone can tell me why the |
Adds AppVeyor configuration file and tweaks the use of temp files in tests so they run properly in the AppVeyor environment.
The tests pass on AppVeyor, but at least the 64-bit jobs should be failing due to |
I know what's happening now, thanks to a push from AppVeyor support and a little digging. PyEnchant bundles libraries for Windows, but the install failures I and other have seen occurred under MSYS2. This AppVeyor config can be further extended to also test on MSYS2 (which is supported)…or we can just say MSYS2 is not a supported environment for Sopel. I'd like to support it—ideally Sopel should run anywhere Python is available. I will dig some more before finalizing this configuration. |
Yeah... except for some command options, like So, this beg the question: do we want to support Windows? If so, I'd push even more for dropping old version of Python, because the matrix support would be already quite huge. |
Well, you know… "run" doesn't mean "all features work identically". 😛 You've already seen the Python version-support plans for the next couple of releases, so don't worry—py2 will go away Real Soon Now™ and we can stop bothering with it. Actually, I decided to bump this into Sopel 8, which is currently planned to drop several old Python versions. |
Six months later, I think I'll abandon this. During the dev cycle for Sopel 8, we'll probably switch from Travis to GitHub Actions. Even if we don't switch, Travis has Windows environments available. No matter what, we'll be able to test on Windows in the same CI tool as Linux builds. |
Adds AppVeyor configuration file and tweaks the use of temp files in tests so they run properly in the AppVeyor environment.
I'm still working on the configuration via test builds attached to my fork, and there have already been several force-pushes to this branch to fix the actual tests (because of how
tempfile
works on Windows vs. Linux) and tweak the build matrix. Expect more before this is ready to merge—especially since AppVeyor has stopped actually running jobs for me, making it impossible to finish testing the config.When complete, this will resolve #1330. (Though I didn't expect to get around to it so soon, which I why I even made the tracking issue. Could be worse.)