Merge pull request #27 from soranjiro/feat/test-new

create test

Author: soranjiro

.github/workflows/ci.yml

@@ -13,11 +13,35 @@ on:
       - "docs/**"
 
 jobs:
-  build-test:
+  test:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
 
+      - name: Setup PNPM
+        uses: pnpm/action-setup@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "pnpm"
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Run API Tests
+        run: pnpm run test:api
+
+      - name: Run Web Tests
+        run: pnpm run test:web
+
+  build:
+    runs-on: ubuntu-latest
+    needs: test
+    steps:
+      - uses: actions/checkout@v4
+
       - name: Setup PNPM
         uses: pnpm/action-setup@v4
 

.husky/pre-push

@@ -0,0 +1 @@
+pnpm run test

Makefile

@@ -1,4 +1,4 @@
-.PHONY: build deploy deploy-api deploy-web dev migrate-local migrate-remote
+.PHONY: build deploy deploy-api deploy-web dev migrate-local migrate-remote test test-api test-web
 
 build:
 	pnpm run build
@@ -19,3 +19,12 @@ migrate-local:
 
 migrate-remote:
 	cd apps/api && pnpm wrangler d1 migrations apply tabitabi --remote
+
+test:
+	pnpm run test
+
+test-api:
+	pnpm run test:api
+
+test-web:
+	pnpm run test:web

apps/api/package.json

@@ -6,16 +6,20 @@
   "scripts": {
     "dev": "wrangler dev",
     "deploy": "wrangler deploy",
-    "migrations:apply": "wrangler d1 migrations apply tabitabi-db"
+    "migrations:apply": "wrangler d1 migrations apply tabitabi-db",
+    "test": "vitest",
+    "test:run": "vitest run"
   },
   "dependencies": {
     "@tsndr/cloudflare-worker-jwt": "^3.2.0",
     "hono": "^4.6.14"
   },
   "devDependencies": {
+    "@cloudflare/vitest-pool-workers": "^0.10.10",
     "@cloudflare/workers-types": "^4.20250110.0",
     "@tabitabi/types": "workspace:*",
     "typescript": "^5.6.3",
+    "vitest": "^3.2.0",
     "wrangler": "^4.38.0"
   }
 }

apps/api/test/env.d.ts

@@ -0,0 +1,5 @@
+import type { Env } from '../src/utils';
+
+declare module 'cloudflare:test' {
+  interface ProvidedEnv extends Env {}
+}

apps/api/test/health.test.ts

@@ -0,0 +1,20 @@
+import {
+  env,
+  createExecutionContext,
+  waitOnExecutionContext,
+} from 'cloudflare:test';
+import { describe, it, expect, beforeEach } from 'vitest';
+import app from '../src/index';
+
+describe('Health Check', () => {
+  it('returns OK', async () => {
+    const request = new Request('http://localhost/health');
+    const ctx = createExecutionContext();
+    const response = await app.fetch(request, env, ctx);
+    await waitOnExecutionContext(ctx);
+
+    expect(response.status).toBe(200);
+    const data = await response.json();
+    expect(data).toEqual({ status: 'ok', service: 'tabitabi-api' });
+  });
+});

apps/api/test/itineraries.test.ts

@@ -0,0 +1,238 @@
+import { env } from 'cloudflare:test';
+import { describe, it, expect, beforeEach } from 'vitest';
+import app from '../src/index';
+
+async function applyMigrations(db: D1Database) {
+  const migrations = [
+    `CREATE TABLE IF NOT EXISTS itineraries (
+      id TEXT PRIMARY KEY,
+      title TEXT NOT NULL,
+      theme_id TEXT NOT NULL DEFAULT 'minimal',
+      memo TEXT,
+      password TEXT,
+      created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+      updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP
+    );`,
+    `CREATE TABLE IF NOT EXISTS steps (
+      id TEXT PRIMARY KEY,
+      itinerary_id TEXT NOT NULL,
+      title TEXT NOT NULL,
+      date TEXT NOT NULL,
+      time TEXT NOT NULL,
+      location TEXT,
+      notes TEXT,
+      created_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+      updated_at TEXT NOT NULL DEFAULT CURRENT_TIMESTAMP,
+      FOREIGN KEY (itinerary_id) REFERENCES itineraries(id) ON DELETE CASCADE
+    );`,
+    `CREATE INDEX IF NOT EXISTS idx_steps_itinerary ON steps(itinerary_id);`,
+    `CREATE TABLE IF NOT EXISTS itinerary_secrets (
+      itinerary_id TEXT PRIMARY KEY,
+      enabled BOOLEAN DEFAULT FALSE,
+      offset_minutes INTEGER DEFAULT 60,
+      created_at TEXT NOT NULL,
+      updated_at TEXT NOT NULL,
+      FOREIGN KEY (itinerary_id) REFERENCES itineraries(id) ON DELETE CASCADE
+    );`,
+    `CREATE TABLE IF NOT EXISTS itinerary_walica_settings (
+      itinerary_id TEXT PRIMARY KEY,
+      walica_id TEXT NOT NULL,
+      created_at TEXT NOT NULL,
+      updated_at TEXT NOT NULL,
+      FOREIGN KEY (itinerary_id) REFERENCES itineraries(id) ON DELETE CASCADE
+    );`,
+  ];
+
+  for (const sql of migrations) {
+    await db.prepare(sql).run();
+  }
+}
+
+describe('Itineraries API', () => {
+  beforeEach(async () => {
+    await applyMigrations(env.DB);
+    await env.DB.prepare('DELETE FROM steps').run();
+    await env.DB.prepare('DELETE FROM itinerary_secrets').run();
+    await env.DB.prepare('DELETE FROM itinerary_walica_settings').run();
+    await env.DB.prepare('DELETE FROM itineraries').run();
+  });
+
+  describe('POST /api/v1/itineraries', () => {
+    it('creates a new itinerary with title', async () => {
+      const request = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Test Trip' }),
+      });
+
+      const response = await app.fetch(request, env);
+      expect(response.status).toBe(201);
+
+      const { success, data } = await response.json() as any;
+      expect(success).toBe(true);
+      expect(data.title).toBe('Test Trip');
+      expect(data.theme_id).toBe('minimal');
+      expect(data.id).toBeDefined();
+      expect(data.token).toBeDefined();
+    });
+
+    it('creates itinerary with custom theme', async () => {
+      const request = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Custom Theme Trip', theme_id: 'standard' }),
+      });
+
+      const response = await app.fetch(request, env);
+      expect(response.status).toBe(201);
+
+      const { data } = await response.json() as any;
+      expect(data.theme_id).toBe('standard');
+    });
+
+    it('creates itinerary with memo', async () => {
+      const request = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Trip with Memo', memo: 'Remember to pack sunscreen' }),
+      });
+
+      const response = await app.fetch(request, env);
+      expect(response.status).toBe(201);
+
+      const { data } = await response.json() as any;
+      expect(data.memo).toBe('Remember to pack sunscreen');
+    });
+  });
+
+  describe('GET /api/v1/itineraries', () => {
+    it('returns empty array when no itineraries exist', async () => {
+      const request = new Request('http://localhost/api/v1/itineraries');
+      const response = await app.fetch(request, env);
+
+      expect(response.status).toBe(200);
+      const { success, data } = await response.json() as any;
+      expect(success).toBe(true);
+      expect(data).toEqual([]);
+    });
+
+    it('returns list of itineraries', async () => {
+      const createRequest = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Trip 1' }),
+      });
+      await app.fetch(createRequest, env);
+
+      const createRequest2 = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Trip 2' }),
+      });
+      await app.fetch(createRequest2, env);
+
+      const request = new Request('http://localhost/api/v1/itineraries');
+      const response = await app.fetch(request, env);
+
+      expect(response.status).toBe(200);
+      const { data } = await response.json() as any;
+      expect(data).toHaveLength(2);
+    });
+  });
+
+  describe('GET /api/v1/itineraries/:id', () => {
+    it('returns itinerary by id', async () => {
+      const createRequest = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'My Trip' }),
+      });
+      const createResponse = await app.fetch(createRequest, env);
+      const { data: created } = await createResponse.json() as any;
+
+      const request = new Request(`http://localhost/api/v1/itineraries/${created.id}`);
+      const response = await app.fetch(request, env);
+
+      expect(response.status).toBe(200);
+      const { data } = await response.json() as any;
+      expect(data.id).toBe(created.id);
+      expect(data.title).toBe('My Trip');
+    });
+
+    it('returns 404 for non-existent itinerary', async () => {
+      const request = new Request('http://localhost/api/v1/itineraries/nonexistent');
+      const response = await app.fetch(request, env);
+
+      expect(response.status).toBe(404);
+      const { success, error } = await response.json() as any;
+      expect(success).toBe(false);
+      expect(error.code).toBe('NOT_FOUND');
+    });
+  });
+
+  describe('PUT /api/v1/itineraries/:id', () => {
+    it('updates itinerary title without password protection', async () => {
+      const createRequest = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Original Title' }),
+      });
+      const createResponse = await app.fetch(createRequest, env);
+      const { data: created } = await createResponse.json() as any;
+
+      const updateRequest = new Request(`http://localhost/api/v1/itineraries/${created.id}`, {
+        method: 'PUT',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Updated Title' }),
+      });
+      const response = await app.fetch(updateRequest, env);
+
+      expect(response.status).toBe(200);
+      const { data } = await response.json() as any;
+      expect(data.title).toBe('Updated Title');
+    });
+
+    it('returns 404 for non-existent itinerary', async () => {
+      const updateRequest = new Request('http://localhost/api/v1/itineraries/nonexistent', {
+        method: 'PUT',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'Updated Title' }),
+      });
+      const response = await app.fetch(updateRequest, env);
+
+      expect(response.status).toBe(404);
+    });
+  });
+
+  describe('DELETE /api/v1/itineraries/:id', () => {
+    it('deletes itinerary without password protection', async () => {
+      const createRequest = new Request('http://localhost/api/v1/itineraries', {
+        method: 'POST',
+        headers: { 'Content-Type': 'application/json' },
+        body: JSON.stringify({ title: 'To Delete' }),
+      });
+      const createResponse = await app.fetch(createRequest, env);
+      const { data: created } = await createResponse.json() as any;
+
+      const deleteRequest = new Request(`http://localhost/api/v1/itineraries/${created.id}`, {
+        method: 'DELETE',
+      });
+      const response = await app.fetch(deleteRequest, env);
+
+      expect(response.status).toBe(200);
+
+      const getRequest = new Request(`http://localhost/api/v1/itineraries/${created.id}`);
+      const getResponse = await app.fetch(getRequest, env);
+      expect(getResponse.status).toBe(404);
+    });
+
+    it('returns 404 for non-existent itinerary', async () => {
+      const deleteRequest = new Request('http://localhost/api/v1/itineraries/nonexistent', {
+        method: 'DELETE',
+      });
+      const response = await app.fetch(deleteRequest, env);
+
+      expect(response.status).toBe(404);
+    });
+  });
+});