use constants for persistent folder

Signed-off-by: Tin Lai <[email protected]>

Author: soraxas

echo360/downloader.py

@@ -6,7 +6,7 @@
 
 from .course import EchoCloudCourse
 from .echo_exceptions import EchoLoginError
-from .utils import naive_versiontuple
+from .utils import naive_versiontuple, PERSISTENT_SESSION_FOLDER
 
 
 from pick import pick
@@ -35,7 +35,7 @@ def build_chrome_driver(
     if not setup_credential:
         opts.add_argument("--headless")
     if persistent_session:
-        folder_path = "_browser_user_data_dir"  # default current dir
+        folder_path = PERSISTENT_SESSION_FOLDER  # default current dir
         opts.add_argument("--user-data-dir={}".format(folder_path))
     opts.add_argument("--window-size=1920x1080")
     opts.add_argument("user-agent={}".format(user_agent))

echo360/main.py

@@ -20,6 +20,7 @@
 from .echo_exceptions import EchoLoginError
 from .downloader import EchoDownloader
 from .course import EchoCourse, EchoCloudCourse
+from .utils import PERSISTENT_SESSION_FOLDER
 
 _DEFAULT_BEFORE_DATE = datetime(2900, 1, 1).date()
 _DEFAULT_AFTER_DATE = datetime(1100, 1, 1).date()
@@ -96,10 +97,14 @@ def handle_args():
     )
     parser.add_argument(
         "--persistent-session",
+        "-P",
         action="store_true",
         default=False,
         dest="persistent_session",
-        help="Starts a persistent session (helps to store credentials). Session uses '_browser_user_data_dir' folder, and currently only supports chrome driver.",
+        help="Starts a persistent session (helps to store credentials). Session uses \
+            '{}' folder, and currently only supports chrome driver.".format(
+            PERSISTENT_SESSION_FOLDER
+        ),
     )
     parser.add_argument(
         "--download-phantomjs-binary",

echo360/utils.py

@@ -4,3 +4,6 @@ def naive_versiontuple(v):
     Expects naive_versiontuple('xx.yy.zz') < naive_versiontuple('aa.bb.cc').
     """
     return tuple(map(int, (v.split("."))))
+
+
+PERSISTENT_SESSION_FOLDER = "_browser_persistent_session"