Report possible unsoundness in sdl2

[sornas]

Dropping the image buffer sent to set_window_icon works fine on Linux and locally on Windows but not when cross compiling from Linux to Windows. We should do a minimal reconstruction and report it.

[sornas]

So this is not enough to reproduce. Will look at it again later.

Details

fn main() {
    let sdl_context = sdl2::init().unwrap();
    let video = sdl_context.video().unwrap();

    let mut window = video.window("sdl window", 400, 400)
        .build()
        .unwrap();

    let mut image: Option<Vec<u8>> = Some(vec![
        255, 0, 0, 255,
        255, 255, 255, 255,
        255, 0, 0, 255,
        255, 255, 255, 255,
    ]);

    let icon = sdl2::surface::Surface::from_data(
        image.as_mut().unwrap(), 2, 2, 8, sdl2::pixels::PixelFormatEnum::RGBA8888
    ).unwrap();
    window.set_icon(icon); // icon moved here

    let mut events = sdl_context.event_pump().unwrap();
    'main: loop {
        for event in events.poll_iter() {
            match event {
                sdl2::event::Event::Quit { .. } => break 'main,
                sdl2::event::Event::KeyDown {
                    ..
                } => {
                    println!("key");
                    image.take();
                }
                _ => (),
            }
        }
    }
}