Handle some uncaught exceptions in explain mode - #2539
Open
yonatan wants to merge 3 commits into
Open
Conversation
…ypes) Catch exceptions from stoi and friends in valueRead and rethrow them with actionable error messages, to be caught and handled in the interactive command loop.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2539 +/- ##
==========================================
- Coverage 81.14% 81.06% -0.09%
==========================================
Files 492 492
Lines 33372 33392 +20
==========================================
- Hits 27080 27068 -12
- Misses 6292 6324 +32
🚀 New features to boost your workflow:
|
Member
|
Hi, @yonatan it would be nice to have a few tests covering this improvement. |
Contributor
Author
|
True, but I probably won't get around to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain mode passes some user input directly to stoi() and friends, which makes it crash on user errors/typos.
For example:
And with this patch: