Using expression beautification with LineCollectionEditingHelper

[bokhary3]

Hi, first—thanks a lot for making SoulverCore, it’s really awesome.

I’m running into a crash when I set:
lineCollection.expressionBeautificationOptions = .defaults

I get an index out of range error here:

// Convert the "local" range of the semantic token in the expression to a range in the text guard let tokenRangeInText = self.helper.convert(localRange: semanticToken.range, toTextRangeOn: lineIndex) else { assertionFailure("Could not get the range in text view for this token: \(semanticToken)") return }

Is this a known issue, or am I maybe missing some required setup when using .lineCollection?
Any advice on how to avoid this crash or configure expressionBeautificationOptions properly?

Thanks again for your work on this library!

[zcohan]

LineCollectionEditingHelper keeps a LineCollection in sync with a text view (not the other way around). The text view is the source of truth, and the helper does not expect the line collection to edit the expressions (which is what expression beautification is, inserting spaces, commas, etc).

You'd need to do this synchronisation yourself if you want to use the line collection's expression beautification feature. I wouldn't recommend touching the LineCollectionEditingHelper at all in this case.

The rough order of operations would look like this:

1. User makes an edit to a line in the text view
2. Update your expression-beautifying line collection with the new expression, & evaluate the line
3. Update your text view with the beautified expression
4. Apply syntax coloring (this could also be performed with the previous step)

[bokhary3]

Thanks for the reply. It's clear now.