feat(core): resolve sonar issues

resolve sonar issues

gh-86

Author: Sunny Tyagi

packages/core/src/__tests__/unit/booters/core-model.booter.unit.test.ts

@@ -29,16 +29,6 @@ describe('CoreModelBooter', () => {
     sinon.restore();
   });
 
-  it('should skip load when component is not found', async () => {
-    const getSyncSpy = sinon.spy(ctx, 'getSync');
-    const booter = new DummyBooter(ctx);
-    await booter.discover();
-    await booter.load();
-
-    // Assert context tried to get the component, but failed silently
-    sinon.assert.calledWith(getSyncSpy, 'components.MyComponent');
-  });
-
   it('should skip load when component has no models', async () => {
     class NoModelComponent implements Component {}
 

packages/core/src/booters/base.booter.ts

@@ -52,33 +52,25 @@ export class BaseBooter implements Booter {
    * NOTE: All properties are configured even if all aren't used.
    */
   async configure() {
-    if (this.options.dirs) {
-      this.dirs = Array.isArray(this.options.dirs)
-        ? this.options.dirs
-        : [this.options.dirs];
-    } else {
-      this.dirs = [];
-    }
+    this.dirs = this.normalizeToArray(this.options.dirs);
+    this.extensions = this.normalizeToArray(this.options.extensions);
 
-    if (this.options.extensions) {
-      this.extensions = Array.isArray(this.options.extensions)
-        ? this.options.extensions
-        : [this.options.extensions];
-    } else {
-      this.extensions = [];
-    }
+    const joinedDirs = this.formatDirs(this.dirs);
+    const joinedExts = `@(${this.extensions.join('|')})`;
 
-    let joinedDirs = this.dirs.join(',');
-    if (this.dirs.length > 1) joinedDirs = `{${joinedDirs}}`;
+    this.glob =
+      this.options.glob ??
+      `/${joinedDirs}/${this.options.nested ? '**/*' : '*'}${joinedExts}`;
+  }
 
-    const joinedExts = `@(${this.extensions.join('|')})`;
+  private normalizeToArray<T>(value: T | T[] | undefined): T[] {
+    if (!value) return [];
+    return Array.isArray(value) ? value : [value];
+  }
 
-    if (this.options.glob) {
-      this.glob = this.options.glob;
-    } else {
-      const pattern = this.options.nested ? '**/*' : '*';
-      this.glob = `/${joinedDirs}/${pattern}${joinedExts}`;
-    }
+  private formatDirs(dirs: string[]): string {
+    if (dirs.length > 1) return `{${dirs.join(',')}}`;
+    return dirs.join(',');
   }
 
   /**