Skip to content

Commit 063be2c

Browse files
committed
♻️ Refactor submodule title composition
1 parent 6992b1e commit 063be2c

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

src/ViewModels/Launcher.cs

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -301,20 +301,13 @@ public void OpenRepositoryInTab(string repo, LauncherPage page)
301301

302302
public void OpenRepositoryInTab(RepositoryNode node, LauncherPage page)
303303
{
304-
// Compose submodule title from current parent name
305-
if (page != null && page.Node.IsRepository)
306-
{
307-
var baseName = Path.GetFileName(node.Id);
308-
node.Name = $"{page.Node.Name} : {baseName}";
309-
}
310-
311304
foreach (var one in Pages)
312305
{
313306
if (one.Node.Id == node.Id)
314307
{
315308
// Update title in case parent was renamed
316309
if (page != null && page.Node.IsRepository)
317-
one.Node.Name = node.Name;
310+
one.Node.Name = ComposeSubmoduleTitle(page, node);
318311

319312
ActivePage = one;
320313
return;
@@ -368,7 +361,7 @@ public void OpenRepositoryInTab(RepositoryNode node, LauncherPage page)
368361
else if (page.Node.IsRepository)
369362
{
370363
var parent = page;
371-
node.Name = $"{parent.Node.Name} : {node.Name}";
364+
node.Name = ComposeSubmoduleTitle(parent, node);
372365
page = new LauncherPage(node, repo);
373366
var parentIdx = Pages.IndexOf(parent);
374367
Pages.Insert(parentIdx + 1, page);
@@ -487,6 +480,12 @@ private void PostActivePageChanged()
487480
CommandPalette = null;
488481
}
489482

483+
private static string ComposeSubmoduleTitle(LauncherPage parent, RepositoryNode node)
484+
{
485+
var baseName = Path.GetFileName(node.Id);
486+
return $"{parent.Node.Name} : {baseName}";
487+
}
488+
490489
private Workspace _activeWorkspace;
491490
private LauncherPage _activePage;
492491
private bool _ignoreIndexChange;

0 commit comments

Comments
 (0)