fix: hide suggestion box when the parent TextBox is invisible (#2662)

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/Views/CommitMessageToolBox.axaml.cs

@@ -379,7 +379,7 @@ protected override void OnKeyDown(KeyEventArgs e)
 
         private void OnLayoutUpdated(object sender, EventArgs e)
         {
-            if (_textPresenter == null)
+            if (_textPresenter == null || !IsEffectivelyVisible)
             {
                 SubjectEndY = 0;
                 SuggestionPopupY = 0;

src/Views/RevisionFiles.axaml

@@ -28,7 +28,8 @@
                  Watermark="{DynamicResource Text.CommitDetail.Files.Search}"
                  Text="{Binding RevisionFileSearchFilter, Mode=TwoWay}"
                  KeyDown="OnSearchBoxKeyDown"
-                 TextChanged="OnSearchBoxTextChanged">
+                 TextChanged="OnSearchBoxTextChanged"
+                 LayoutUpdated="OnSearchBoxLayoutUpdated">
           <TextBox.InnerLeftContent>
             <Path Width="14" Height="14" Margin="4,0,0,0" Fill="{DynamicResource Brush.FG2}" Data="{StaticResource Icons.Search}"/>
           </TextBox.InnerLeftContent>

src/Views/RevisionFiles.axaml.cs

@@ -1,3 +1,4 @@
+using System;
 using Avalonia.Controls;
 using Avalonia.Input;
 using Avalonia.Interactivity;
@@ -31,7 +32,7 @@ private async void OnSearchBoxKeyDown(object _, KeyEventArgs e)
             {
                 if (vm.RevisionFileSearchSuggestion?.Count > 0)
                 {
-                    SearchSuggestionBox.Focus(NavigationMethod.Tab);
+                    SearchSuggestionBox.Focus(NavigationMethod.Directional);
                     SearchSuggestionBox.SelectedIndex = 0;
                 }
 
@@ -50,6 +51,15 @@ private async void OnSearchBoxTextChanged(object _, TextChangedEventArgs e)
                 await FileTree.SetSearchResultAsync(null);
         }
 
+        private void OnSearchBoxLayoutUpdated(object sender, EventArgs e)
+        {
+            if (DataContext is not ViewModels.CommitDetail vm)
+                return;
+
+            if (sender is TextBox { IsEffectivelyVisible: false })
+                vm.CancelRevisionFileSuggestions();
+        }
+
         private async void OnSearchSuggestionBoxKeyDown(object _, KeyEventArgs e)
         {
             if (DataContext is not ViewModels.CommitDetail vm)