Fix verbose option in CLI mode (#28)

Before, `v` would always be false, so the `-verbose` option never
worked.

Author: tobyhs

main.go

@@ -103,18 +103,19 @@ func cliOptions(stdout io.Writer, args []string) (*options, error) {
 	flags.StringVar(&opts.format, "format", "text", "The format of the output: text or markdown")
 	flags.StringVar(&opts.filename, "filename", "CODENOTIFY", "The filename in which file subscribers are defined")
 	flags.IntVar(&opts.subscriberThreshold, "subscriber-threshold", 0, "The threshold of notifying subscribers")
-	v := *flags.Bool("verbose", false, "Verbose messages printed to stderr")
+	var v bool
+	flags.BoolVar(&v, "verbose", false, "Verbose messages printed to stderr")
+
+	if err := flags.Parse(args); err != nil {
+		return nil, err
+	}
 
 	if v {
 		verbose = os.Stderr
 	} else {
 		verbose = ioutil.Discard
 	}
 
-	if err := flags.Parse(args); err != nil {
-		return nil, err
-	}
-
 	opts.print = func(notifs map[string][]string) error {
 		return opts.writeNotifications(stdout, notifs)
 	}

main_test.go

@@ -3,6 +3,7 @@ package main
 import (
 	"bytes"
 	"fmt"
+	"io"
 	"io/ioutil"
 	"os"
 	"os/exec"
@@ -129,6 +130,37 @@ func TestMain(t *testing.T) {
 	}
 }
 
+func TestCliOptions(t *testing.T) {
+	var originalVerbose io.Writer = verbose
+	defer func() { verbose = originalVerbose }()
+	tests := []struct {
+		name    string
+		args    []string
+		verbose io.Writer
+	}{
+		{
+			name:    "no arguments",
+			args:    []string{},
+			verbose: ioutil.Discard,
+		},
+		{
+			name:    "verbose option",
+			args:    []string{"-verbose"},
+			verbose: os.Stderr,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			stdout := &bytes.Buffer{}
+			cliOptions(stdout, test.args)
+			if verbose != test.verbose {
+				t.Errorf("expected verbose to be %v; got %v", test.verbose, verbose)
+			}
+		})
+	}
+}
+
 func TestWriteNotifications(t *testing.T) {
 	tests := []struct {
 		name   string