Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Commit 0b84c16

Browse files
authored
Fix auth form validation (#8178)
The validate error for the instance url gets reset when access token is entered. This PR fixes it. ## Test plan Follow plan from: https://github.com/sourcegraph/cody/pull/8174
1 parent 14a5e7f commit 0b84c16

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

vscode/webviews/AuthPage.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -339,10 +339,10 @@ const ClientSignInForm: React.FC<ClientSignInFormProps> = memo(
339339
const handleInputChange = useCallback(
340340
(e: React.ChangeEvent<HTMLInputElement>) => {
341341
const { name, value } = e.target
342-
const validationError = name === 'endpoint' ? validateEndpointUrl(value) : ''
343342
setFormState(prev => ({
344343
...prev,
345-
validationError: validationError || '',
344+
validationError:
345+
name === 'endpoint' ? validateEndpointUrl(value) || '' : prev.validationError,
346346
formData: { ...prev.formData, [name]: value },
347347
}))
348348
},
@@ -416,7 +416,7 @@ const ClientSignInForm: React.FC<ClientSignInFormProps> = memo(
416416
<FormMessage match="typeMismatch">Invalid URL.</FormMessage>
417417
<FormMessage match="valueMissing">URL is required.</FormMessage>
418418
{formState.validationError && (
419-
<div className="tw-text-red-600 tw-text-sm tw-mt-1">
419+
<div className="tw-text-red-500 tw-text-sm tw-mt-1 tw-font-medium">
420420
{formState.validationError}
421421
</div>
422422
)}

vscode/webviews/components/UserMenu.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ export const UserMenu: React.FunctionComponent<UserMenuProps> = ({
230230
URL is required.
231231
</FormMessage>
232232
{validationError && (
233-
<div className="tw-text-red-600 tw-text-sm tw-mt-1">
233+
<div className="tw-text-red-500 tw-text-sm tw-mt-1 tw-font-medium">
234234
{validationError}
235235
</div>
236236
)}

0 commit comments

Comments
 (0)