Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Commit 2f5c7ea

Browse files
tomaszgolebiowskiTomasz Gołębiowski
andauthored
Improve Visual Studio themes (#8152)
These changes improve menu coloring in the chat window and in the @ menu. The change is mainly visible in blue/blue (extra contrast) themes. Before ![Before](https://github.com/user-attachments/assets/8569eb84-a2b8-4852-bd8f-1a70c665e8a4) After ![After](https://github.com/user-attachments/assets/ac745803-a4e1-4a38-a5f9-949a0d5adccb) ## Test plan Change the theme color to Blue (extra contrast) and compare with the screenshot above. <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> Co-authored-by: Tomasz Gołębiowski <tgolebiowski@virtuslab.com>
1 parent 4896593 commit 2f5c7ea

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

vscode/webviews/themes/visual-studio.css

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ html[data-ide='VisualStudio'] {
101101
/* --vscode-diffEditor-unchangedRegionShadow: var(); */
102102
/* --vscode-disabledForeground: var(); */
103103
--vscode-dropdown-background: var(--visualstudio-dropdownbackground);
104-
--vscode-dropdown-border: var(--visualstudio-dropdownborder);
104+
--vscode-dropdown-border: var(--visualstudio-commandbarmenuseparator);
105105
--vscode-dropdown-foreground: var(--visualstudio-dropdowntext);
106106
--vscode-dropdown-listBackground: var(--visualstudio-dropdownmouseoverbackgroundend);
107107
--vscode-editor-background: var(--visualstudio-editorexpansionfill);
@@ -261,12 +261,12 @@ html[data-ide='VisualStudio'] {
261261
/* --vscode-extensionIcon-starForeground: var(); */
262262
/* --vscode-extensionIcon-verifiedForeground: var(); */
263263
--vscode-focusBorder: var(--visualstudio-comboboxborder);
264-
--vscode-foreground: var(--visualstudio-toolwindowtext);
264+
--vscode-foreground: var(--visualstudio-systemmenutext);
265265
--vscode-icon-foreground: var(--visualstudio-comboboxtext);
266266
--vscode-input-background: var(--visualstudio-comboboxbackground);
267267
--vscode-input-border: var(--visualstudio-comboboxborder);
268268
--vscode-input-foreground: var(--visualstudio-comboboxtext);
269-
--vscode-input-placeholderForeground: var(--visualstudio-comboboxitemtextinactive);
269+
--vscode-input-placeholderForeground: var(--visualstudio-commandbarmenuwatermarktext);
270270
--vscode-inputOption-activeBackground: var(--visualstudio-startpagetextcontrollinkselected);
271271
--vscode-inputOption-activeBorder: var(--visualstudio-startpagetextcontrollinkselected);
272272
--vscode-inputOption-activeForeground: var(--visualstudio-startpagetextbody);
@@ -290,8 +290,8 @@ html[data-ide='VisualStudio'] {
290290
/* --vscode-list-hoverBackground: var(); */
291291
--vscode-list-invalidItemForeground: var(--visualstudio-toolwindowvalidationerrortext);
292292
--vscode-list-inactiveSelectionBackground: var(--visualstudio-sortbackground);
293-
--vscode-list-activeSelectionForeground: var(--visualstudio-sorttext);
294-
--vscode-list-activeSelectionBackground: var(--visualstudio-sortbackground);
293+
--vscode-list-activeSelectionForeground: var(--visualstudio-commandbarmenuitemmouseovertext);
294+
--vscode-list-activeSelectionBackground: var(--visualstudio-commandbarmenuitemmouseover);
295295
/* --vscode-listFilterWidget-background: var(); */
296296
/* --vscode-listFilterWidget-noMatchesOutline: var(); */
297297
/* --vscode-listFilterWidget-outline: var(); */
@@ -383,7 +383,7 @@ html[data-ide='VisualStudio'] {
383383
/* --vscode-profileBadge-background: var(); */
384384
/* --vscode-profileBadge-foreground: var(); */
385385
/* --vscode-progressBar-background: var(); */
386-
--vscode-quickInput-background: var(--visualstudio-filetabbackground);
386+
--vscode-quickInput-background: var(--visualstudio-commandbarmenuiconbackground);
387387
--vscode-quickInput-foreground: var(--visualstudio-comboboxtext);
388388
--vscode-quickInputTitle-background: var(--visualstudio---visualstudio-filetabselectedbackground);
389389
/* --vscode-remoteHub-decorations-addedForegroundColor: var(); */
@@ -583,6 +583,7 @@ html[data-ide='VisualStudio'] {
583583
/* --vscode-widget-border: var(); */
584584
--vscode-window-activeBorder: var(--visualstudio-titlebaractiveborder);
585585
--vscode-window-inactiveBorder: var(--visualstudio-titlebarinactive);
586+
/* --button-icon-background: var(--visualstudio-filetabbackground); */
586587
--foreground: var(--visualstudio-toolwindowtext);
587588

588589
/* Mimic rules injected by VSCode */
@@ -627,6 +628,11 @@ html[data-ide='VisualStudio'] pre code {
627628
padding: 0;
628629
}
629630

631+
/* hide menu borders */
632+
html[data-ide='VisualStudio'] [id='radix-:r6:'] {
633+
padding: 0 !important;
634+
}
635+
630636
html[data-ide='VisualStudio'] blockquote {
631637
background: var(--vscode-textBlockQuote-background);
632638
border-color: var(--vscode-textBlockQuote-border);

0 commit comments

Comments
 (0)