Fix auto-edit enrolment issue caused by config propagation bug (#8140)

There was a bug in `affectsConfiguration`. We are looking for a key in
the section (not the other way). This PR fixes that. It likely fixes
some other config propagation / sync issues. In particular, it makes
auto-edits available just after the enrolment.

## Test plan
Tested manually. Sadly, auto-edit case needs some code tweaks.
You can checkout my other branch based on this one that provides the
necessary functionalities:
[[DO NOT MERGE] Auto-edit enrol
testing](https://github.com/sourcegraph/cody/pull/8141#top)

<!-- Required. See
https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles.
-->

---------

Co-authored-by: Tom Ross <tom@umpox.com>

Author: mkondratek

agent/recordings/autocomplete_2136217965/recording.har.yaml

@@ -2,18 +2,6 @@
 
 exports[`Autocomplete > autocomplete/execute multiline (non-empty result) 1`] = `
 [
-  "let swapped: boolean
-    do {
-        swapped = false
-        for (let i = 0; i < arr.length - 1; i++) {
-            if (arr[i] > arr[i + 1]) {
-                const temp = arr[i]
-                arr[i] = arr[i + 1]
-                arr[i + 1] = temp
-                swapped = true
-            }
-        }
-    } while (swapped)
-    return arr",
+  "return arr;",
 ]
 `;

agent/src/__snapshots__/autocomplete.test.ts.snap

@@ -112,7 +112,12 @@ describe('Enterprise - S2 (close main branch)', { timeout: 5000 }, () => {
 
         // The site config `cody.contextFilters` value on sourcegraph.sourcegraph.com instance
         // should include `sourcegraph/cody` repo for this test to pass.
-        it('autocomplete/execute (with Cody Ignore filters)', async () => {
+        // Note: This test has been skipped as relying on live site config for tests causes problems
+        // later on when that site config has changed and the tests have not been run for a while.
+        // This issue is exacerbated by the fact that the changes to site config do not trigger a
+        // re-run of the tests, so the issue is not caught until the next time the recordings
+        // are updated.
+        it.skip('autocomplete/execute (with Cody Ignore filters)', async () => {
             // Documents to be used as context sources.
             await s2EnterpriseClient.openFile(animalUri)
             await s2EnterpriseClient.openFile(squirrelUri)

agent/src/enterprise-s2.test.ts

@@ -180,7 +180,7 @@ const configuration = new AgentWorkspaceConfiguration(
     async (section, value) => {
         if (onDidChangeConfiguration) {
             await onDidChangeConfiguration.cody_fireAsync({
-                affectsConfiguration: key => key.includes(section),
+                affectsConfiguration: prefix => section.includes(prefix),
             })
         }
 

agent/src/vscode-shim.ts

@@ -9,7 +9,6 @@ import {
     telemetryRecorder,
 } from '@sourcegraph/cody-shared'
 import * as vscode from 'vscode'
-import { isRunningInsideAgent } from '../jsonrpc/isRunningInsideAgent'
 import { localStorage } from '../services/LocalStorageProvider'
 import { isUserEligibleForAutoeditsFeature } from './create-autoedits-provider'
 
@@ -39,9 +38,8 @@ export class AutoEditBetaOnboarding implements vscode.Disposable {
         this.markUserAsAutoEditBetaEnrolled()
         this.writeAutoeditNotificationEvent()
 
-        const clientsSuffix = isRunningInsideAgent() ? 'Restart your IDE to apply the changes. ' : ''
         const selection = await vscode.window.showInformationMessage(
-            `You have been enrolled to Cody Auto-edit! ${clientsSuffix}Cody will intelligently suggest next edits as you navigate the codebase.`,
+            'You have been enrolled to Cody Auto-edit! Cody will intelligently suggest next edits as you navigate the codebase.',
             switchToAutocompleteText
         )