Skip to content
This repository was archived by the owner on Aug 1, 2025. It is now read-only.

Commit f4280dc

Browse files
chore(ci): resolve issue with artifacts naming (#8195)
When a failure occurs in the e2e tests, we upload some of the artifacts for access. However, the naming of this artifact isn't unique and when an artifact with the same name exists, it throws an error. This PR makes the artifact name unique and overwrites it in the event that running the workflow multiple times returns an error ## Test plan <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> * CI --------- Co-authored-by: David Ichim <ichim.david@gmail.com>
1 parent 1f2cec5 commit f4280dc

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,11 @@ jobs:
186186
- uses: actions/upload-artifact@v4
187187
if: ${{ failure() }}
188188
with:
189-
name: playwright-recordings ${{ matrix.runner }}
189+
name: playwright-recordings-${{ github.event.pull_request.number || github.ref }}-${{ matrix.runner }}
190190
path: |
191191
playwright/
192192
vscode/test-results/
193+
overwrite: true
193194

194195
build:
195196
runs-on: ubuntu-latest

vscode/src/utils/plg-es-access.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// PLG ES access is disabled after July 23, 2025 10:00 AM PST
2-
const PLG_ES_ACCESS_DISABLE_DATE = new Date('2025-07-23T18:00:00.000Z')
2+
const PLG_ES_ACCESS_DISABLE_DATE = new Date('2025-07-24T18:00:00.000Z')
33

44
export function isPlgEsAccessDisabled(): boolean {
55
return new Date() > PLG_ES_ACCESS_DISABLE_DATE

0 commit comments

Comments
 (0)