Skip to content

Commit 58fd70f

Browse files
authored
Update comments in override.yaml for clarity
Clarified comments regarding RBAC resources and HAProxy timeout in override.yaml.
1 parent 97d978c commit 58fd70f

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

charts/sourcegraph/examples/openshift/override.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@
1111
# RBAC
1212
# Some cluster security policies may block the Helm chart from creating RBAC resources,
1313
# such as service accounts, roles, and role bindings.
14-
# Sourcegraph only uses RBAC resources for Kubernetes service discovery, and
15-
# workarounds are available if needed
14+
# Sourcegraph only uses RBAC resources for Kubernetes service discovery, so that
15+
# frontend and Prometheus can find how many replicas of gitserver, indexServer,
16+
# searcher, and worker are running. Workarounds are available if needed:
17+
# https://sourcegraph.com/docs/self-hosted/deploy/without-service-discovery
1618
#
1719
# UID / GID / fsGroup
1820
# Containers must run as UID / GID / fsGroup numbers assigned when the OpenShift
@@ -41,9 +43,11 @@
4143
# Ingress / Router
4244
#
4345
# HAProxy router timeout
44-
# OpenShift's default HAProxy router has a 30-60s timeout
46+
# OpenShift's default HAProxy router has a 30 or 60s timeout by default
4547
# Features like Deep Search streaming (SSE) require longer-lived connections
4648
# Add the haproxy timeout annotation to your Route
49+
# And check for any other proxies upstream which may require overrides, if extending
50+
# the HAProxy timeout doesn't resolve SSE issues
4751
#
4852
# TLS termination
4953
# Likely handled at the Route level via edge termination

0 commit comments

Comments
 (0)