feat: error on banned functions

There were multiple cases recently of stray test.only() committed to master.
This prevents those cases.

Author: felixfbecker

.eslintrc.js

@@ -26,7 +26,7 @@ module.exports = {
     'arrow-body-style': 'error',
     'arrow-parens': ['error', 'as-needed'],
     'ban/ban': [
-      'warn',
+      'error',
       {
         name: ['*', 'forEach'],
         message: 'Use a for-of loop instead',
@@ -41,7 +41,7 @@ module.exports = {
       },
       {
         name: ['jest', 'fn'],
-        message: 'Use sinon.spy(() => {}) instead',
+        message: 'Use sinon.spy(() => undefined) instead',
       },
     ],
     'callback-return': 'error',

package.json

@@ -38,7 +38,7 @@
     "@typescript-eslint/eslint-plugin": "^2.14.0",
     "@typescript-eslint/parser": "^2.14.0",
     "eslint-config-prettier": "^6.9.0",
-    "eslint-plugin-ban": "^1.3.0",
+    "eslint-plugin-ban": "^1.4.0",
     "eslint-plugin-etc": "^0.0.1-beta.24",
     "eslint-plugin-import": "^2.19.1",
     "eslint-plugin-jsdoc": "^19.2.0",

yarn.lock

@@ -1497,10 +1497,10 @@ eslint-module-utils@^2.4.1:
     debug "^2.6.9"
     pkg-dir "^2.0.0"
 
-eslint-plugin-ban@^1.3.0:
-  version "1.3.0"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-ban/-/eslint-plugin-ban-1.3.0.tgz#be9714cb9e01a1adec6c86cdb182e97636eafe44"
-  integrity sha512-A9A2z60UeVj7/BdKzeIjVEGAog/4QXAyOkZ98AUnZc7fsRp+J7YW7+U/YEVpBJqjSiU/FGUA5tGJoI34ul/TyA==
+eslint-plugin-ban@^1.4.0:
+  version "1.4.0"
+  resolved "https://registry.npmjs.org/eslint-plugin-ban/-/eslint-plugin-ban-1.4.0.tgz#b3a7b000412921336b1feeece5b8ce9a69dea605"
+  integrity sha512-wtrUOLg8WUiGDkVnmyMseLRtXYBM+bJTe2STvhqznHVj6RPAiNEVLbvDj2b0WWwY/2ldKqeaw3iHUHwfCJ8c8Q==
   dependencies:
     requireindex "~1.2.0"