Emit external symbol information

Amp-Thread-ID: https://ampcode.com/threads/T-01a029e2-5095-710a-9cce-0c6d8645c173

Author: eseliger

src/main.test.ts

@@ -88,6 +88,25 @@ for (const snapshotDirectory of snapshotDirectories) {
         document.symbols.map(symbol => symbol.symbol)
       )
     )
+    const externalSymbolInformation = new Set(
+      index.external_symbols.map(symbol => symbol.symbol)
+    )
+    assert.equal(
+      externalSymbolInformation.size,
+      index.external_symbols.length,
+      'external SymbolInformation should be unique'
+    )
+    assert.equal(
+      index.external_symbols
+        .map(symbol => symbol.symbol)
+        .filter(symbol => symbolInformation.has(symbol)),
+      [],
+      'symbols should not be both internal and external'
+    )
+    const availableSymbols = new Set([
+      ...symbolInformation,
+      ...externalSymbolInformation,
+    ])
     const indexedPackages = new Set(
       [...symbolInformation]
         .filter(symbol => !symbol.startsWith('local '))
@@ -121,6 +140,19 @@ for (const snapshotDirectory of snapshotDirectories) {
         [],
         `${document.relative_path} should not contain duplicate occurrences`
       )
+      const missingOccurrenceSymbols = document.occurrences
+        .map(occurrence => occurrence.symbol)
+        .filter(
+          symbol =>
+            symbol &&
+            !symbol.startsWith('local ') &&
+            !availableSymbols.has(symbol)
+        )
+      assert.equal(
+        missingOccurrenceSymbols,
+        [],
+        `${document.relative_path} global occurrences should have SymbolInformation`
+      )
       const missingInternalSymbols = document.occurrences
         .map(occurrence => occurrence.symbol)
         .filter(
@@ -157,7 +189,7 @@ for (const snapshotDirectory of snapshotDirectories) {
         ? fs.readFileSync(outputPath).toString()
         : ''
       const input = Input.fromFile(inputPath)
-      const obtained = formatSnapshot(input, document)
+      const obtained = formatSnapshot(input, document, index.external_symbols)
       if (obtained === expected) {
         // Test passed
         continue

src/main.ts

@@ -46,8 +46,20 @@ export function indexCommand(
   }
   const output = fs.openSync(options.output, 'w')
   let documentCount = 0
+  const definedSymbols = new Set<string>()
+  const occurrenceSymbols = new Set<string>()
   const writeIndex = (index: scip.scip.Index): void => {
     documentCount += index.documents.length
+    for (const document of index.documents) {
+      for (const symbol of document.symbols) {
+        definedSymbols.add(symbol.symbol)
+      }
+      for (const occurrence of document.occurrences) {
+        if (occurrence.symbol && !occurrence.symbol.startsWith('local ')) {
+          occurrenceSymbols.add(occurrence.symbol)
+        }
+      }
+    }
     fs.writeSync(output, index.serializeBinary())
   }
 
@@ -85,6 +97,13 @@ export function indexCommand(
         cache
       )
     }
+    writeIndex(
+      new scip.scip.Index({
+        external_symbols: [...occurrenceSymbols]
+          .filter(symbol => !definedSymbols.has(symbol))
+          .map(symbol => new scip.scip.SymbolInformation({ symbol })),
+      })
+    )
   } finally {
     fs.close(output)
     if (documentCount > 0) {