fix/query: resolve type lifting after OR parsing (#1023)

The parser used to lift `type:` directives before converting `or` placeholders into real boolean nodes. That let parse-time `orOp` sentinels leak into `Type` children for unparenthesized queries and allowed malformed inputs like `type:repo or` to parse successfully until runtime.

Resolve operator placeholders before wrapping with `Type` so unparenthesized `or` inside a type scope produces a valid `Or` subtree and malformed `or` placement is rejected during parsing. The docs now clarify that `type:` applies to the whole expression in its current scope, including `or` clauses.

Amp-Thread-ID: https://ampcode.com/threads/T-019d0be7-4c9d-76fd-b556-103420d14be9
Co-authored-by: Amp <amp@ampcode.com>

Author: keegancsmith

doc/query_syntax.md

@@ -111,6 +111,11 @@ This returns repository names instead of file matches. Valid values include:
 - `filename` - Returns only matching filenames
 - `repo` - Returns only repository names
 
+`type:` applies to the whole expression in its current scope, including `or`
+clauses. For example, `type:repo foo or bar` is equivalent to
+`type:repo (foo or bar)`. Use parentheses to scope `type:` to only one branch,
+for example `(type:repo foo) or bar`.
+
 ---
 
 ## Special Query Values

query/parse.go

@@ -416,7 +416,11 @@ func parseExprList(in []byte) ([]Q, int, error) {
 		return q
 	})
 	if typeT != 100 {
-		qs = []Q{&Type{Type: typeT, Child: NewAnd(qs...)}}
+		typedQ, err := parseOperators(qs)
+		if err != nil {
+			return nil, 0, err
+		}
+		qs = []Q{&Type{Type: typeT, Child: typedQ}}
 	}
 
 	if hasCaseScope {

query/parse_test.go

@@ -132,6 +132,7 @@ func TestParseQuery(t *testing.T) {
 		// type
 		{"type:repo abc", &Type{Type: TypeRepo, Child: &Substring{Pattern: "abc"}}},
 		{"type:file abc def", &Type{Type: TypeFileName, Child: NewAnd(&Substring{Pattern: "abc"}, &Substring{Pattern: "def"})}},
+		{"type:repo foo or bar", &Type{Type: TypeRepo, Child: NewOr(&Substring{Pattern: "foo"}, &Substring{Pattern: "bar"})}},
 		{"(type:repo abc) def", NewAnd(&Type{Type: TypeRepo, Child: &Substring{Pattern: "abc"}}, &Substring{Pattern: "def"})},
 
 		// errors.
@@ -144,6 +145,8 @@ func TestParseQuery(t *testing.T) {
 		{"abc or", nil},
 		{"or abc", nil},
 		{"def or or abc", nil},
+		{"type:repo or", nil},
+		{"or type:repo", nil},
 
 		// unbalanced parentheses
 		{"(", nil},