Merge branch 'develop' into combined-bot-prs-branch

Author: shahzadlone

cbindings/node_close.go

@@ -27,10 +27,10 @@ func CloseNode(nodePtr C.uintptr_t) C.Result {
 	if err != nil {
 		return returnC(returnGoC(1, err.Error(), ""))
 	}
-	err = node.Close(context.Background())
-	if err != nil {
+	defer cgo.Handle(nodePtr).Delete()
+
+	if err := node.Close(context.Background()); err != nil {
 		return returnC(GoCResult{1, err.Error(), ""})
 	}
-	cgo.Handle(nodePtr).Delete()
 	return returnC(GoCResult{0, "", ""})
 }

internal/request/graphql/parser/errors.go

@@ -28,4 +28,5 @@ var (
 	ErrInvalidFilterConditions        = errors.New("invalid filter condition type, expected map")
 	ErrMultipleOrderFieldsDefined     = errors.New("each order argument can only define one field")
 	ErrMultipleDocIDsNotSupported     = errors.New("querying by multiple docIDs is not yet supported")
+	ErrSimilarityMissingTarget        = errors.New("similarity requires a target field argument")
 )

internal/request/graphql/parser/query.go

@@ -250,6 +250,11 @@ func parseSimilarity(
 		v := arguments[target].(map[string]any)
 		vector = v[types.SimilarityArgVector]
 	}
+	// The argument names the field to compare against, so without one there is nothing to
+	// compare. The mapper looks the target up by name and would panic on the empty name.
+	if target == "" {
+		return nil, ErrSimilarityMissingTarget
+	}
 
 	return &request.Similarity{
 		Field: request.Field{

tests/integration/query/simple/with_similarity_test.go

@@ -517,3 +517,26 @@ func TestQuerySimple_WithTwoSimilarityAndFilteringOnBoth_ShouldSucceed(t *testin
 
 	testUtils.ExecuteTestCase(t, test)
 }
+
+func TestQuerySimple_WithSimilarityAndNoArguments_ShouldError(t *testing.T) {
+	test := testUtils.TestCase{
+		Actions: []any{
+			&action.AddCollection{
+				SDL: `type User {
+					name: String
+					vector: [Int!]
+				}`,
+			},
+			&action.Request{
+				Request: `query {
+					User {
+						SIMILARITY
+					}
+				}`,
+				ExpectedError: "similarity requires a target field argument",
+			},
+		},
+	}
+
+	testUtils.ExecuteTestCase(t, test)
+}