removed vector index kind from Kind enum

Author: jsimnz

internal/request/graphql/schema/collection.go

@@ -751,13 +751,9 @@ func vectorIndexFromAST(
 		return client.NewIndexRequest{}, ErrIndexWithInvalidArg
 	}
 
-	obj := &ast.ObjectValue{}
-	if config != nil {
-		var ok bool
-		obj, ok = config.(*ast.ObjectValue)
-		if !ok {
-			return client.NewIndexRequest{}, ErrIndexWithInvalidArg
-		}
+	obj, ok := config.(*ast.ObjectValue)
+	if !ok {
+		return client.NewIndexRequest{}, ErrIndexWithInvalidArg
 	}
 
 	var dimensions uint32

internal/request/graphql/schema/index_parse_test.go

@@ -453,13 +453,6 @@ func TestParseInvalidIndexOnField(t *testing.T) {
 			}`,
 			expectedErr: errIndexInvalidArgument,
 		},
-		{
-			description: "vector kind conflicts with ordered config",
-			sdl: `type user {
-				name: String @index(kind: vector, ordered: {})
-			}`,
-			expectedErr: errIndexInvalidArgument,
-		},
 		{
 			description: "ordered and vector configs are competing kind selectors",
 			sdl: `type user {

internal/request/graphql/schema/testfixtures/schema.relatedmany.gen.graphql

@@ -1550,8 +1550,6 @@ input IndexField {
 enum IndexKind {
     "ordered scalar index"
     ordered
-    "vector index"
-    vector
 }
 
 "The `Int` scalar type represents non-fractional signed whole numeric values. Int can represent values between -(2^31) and 2^31 - 1. "

internal/request/graphql/schema/testfixtures/schema.relatedone.gen.graphql

@@ -1493,8 +1493,6 @@ input IndexField {
 enum IndexKind {
     "ordered scalar index"
     ordered
-    "vector index"
-    vector
 }
 
 "The `Int` scalar type represents non-fractional signed whole numeric values. Int can represent values between -(2^31) and 2^31 - 1. "

internal/request/graphql/schema/testfixtures/schema.simple.gen.graphql

@@ -803,8 +803,6 @@ input IndexField {
 enum IndexKind {
     "ordered scalar index"
     ordered
-    "vector index"
-    vector
 }
 
 "The `Int` scalar type represents non-fractional signed whole numeric values. Int can represent values between -(2^31) and 2^31 - 1. "

internal/request/graphql/schema/types/types.go

@@ -117,10 +117,6 @@ func IndexKindEnum() *gql.Enum {
 				Description: "ordered scalar index",
 				Value:       OrderedIndexKind,
 			},
-			VectorIndexKind: &gql.EnumValueConfig{
-				Description: "vector index",
-				Value:       VectorIndexKind,
-			},
 		},
 	})
 }

internal/request/graphql/schema/vector_index_parse_test.go

@@ -71,48 +71,6 @@ func TestParseVectorIndex_OnField_ParsesArgsAndDefaults(t *testing.T) {
 				},
 			},
 		},
-		{
-			description: "vector kind uses vector and HNSW defaults",
-			sdl: `type user {
-				embedding: [Float32!] @index(kind: vector)
-			}`,
-			targetDescriptions: []client.NewIndexRequest{
-				{
-					Fields: []client.IndexedFieldDescription{
-						{Name: "embedding"},
-					},
-					Vector: &client.VectorIndexDescription{
-						Algorithm: client.VectorAlgorithmHNSW,
-						Metric:    client.DistanceMetricCosine,
-						HNSW: &client.HNSWParams{
-							M:              16,
-							EfConstruction: 128,
-							EfSearch:       64,
-						},
-					},
-				},
-			},
-		},
-		{
-			description: "matching kind and vector config are allowed",
-			sdl: `type user {
-				embedding: [Float32!] @index(kind: vector, vector: {})
-			}`,
-			targetDescriptions: []client.NewIndexRequest{
-				{
-					Fields: []client.IndexedFieldDescription{{Name: "embedding"}},
-					Vector: &client.VectorIndexDescription{
-						Algorithm: client.VectorAlgorithmHNSW,
-						Metric:    client.DistanceMetricCosine,
-						HNSW: &client.HNSWParams{
-							M:              16,
-							EfConstruction: 128,
-							EfSearch:       64,
-						},
-					},
-				},
-			},
-		},
 	}
 
 	for _, test := range cases {
@@ -154,6 +112,13 @@ func TestParseVectorIndex_OnField_ProducesVectorKindIndex(t *testing.T) {
 
 func TestParseVectorIndex_InvalidArgs_ReturnsError(t *testing.T) {
 	cases := []invalidIndexTestCase{
+		{
+			description: "vector is not an index kind",
+			sdl: `type user {
+				embedding: [Float32!] @index(kind: vector)
+			}`,
+			expectedErr: `Expected type "IndexKind", found vector`,
+		},
 		{
 			description: "unknown algorithm enum",
 			sdl: `type user {

tests/integration/collection_version/vector_index_test.go

@@ -64,7 +64,7 @@ func TestCollectionVersion_VectorIndexOnFloat32ArrayWithoutDimensionsOrEmbedding
 			&action.AddCollection{
 				SDL: `
 					type Users {
-						embedding: [Float32!] @index(kind: vector)
+						embedding: [Float32!] @index(vector: {})
 					}
 				`,
 				ExpectedError: "vector index dimensions must be greater than zero",