Skip to content

Commit a7a15b7

Browse files
committed
removed test comments
1 parent 8fb7e97 commit a7a15b7

2 files changed

Lines changed: 0 additions & 12 deletions

File tree

tests/integration/query/one_to_many/with_group_unselected_field_test.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ var booksByThreeAuthors = []any{
6969
},
7070
}
7171

72-
// Regression test for https://github.com/sourcenetwork/defradb/issues/4954 for the related-id
73-
// field. Grouping by the foreign-key id must still occur even when the id is not rendered.
7472
func TestQueryOneToManyWithGroupByRelatedIDWithoutRenderedGroupField(t *testing.T) {
7573
test := testUtils.TestCase{
7674
Actions: append(
@@ -107,9 +105,6 @@ func TestQueryOneToManyWithGroupByRelatedIDWithoutRenderedGroupField(t *testing.
107105
executeTestCase(t, test)
108106
}
109107

110-
// Grouping by the relation object field name while also rendering the foreign-key id. This
111-
// exercises the path where the fetched group-by dependency and an explicitly selected field
112-
// resolve to the same underlying field, ensuring the id is rendered exactly once per group.
113108
func TestQueryOneToManyWithGroupByRelationObjectRenderingRelatedID(t *testing.T) {
114109
test := testUtils.TestCase{
115110
Actions: append(

tests/integration/query/simple/with_group_unselected_field_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@ import (
1818
testUtils "github.com/sourcenetwork/defradb/tests/integration"
1919
)
2020

21-
// This is a regression test for https://github.com/sourcenetwork/defradb/issues/4954.
22-
//
23-
// Grouping must still occur on the grouped-by field even when that field is not part of
24-
// the parent's selection set. Previously the field was never fetched, so every document
25-
// produced an identical (nil) group key and all documents collapsed into a single group.
2621
func TestQuerySimpleWithGroupByNumberWithoutRenderedGroupField(t *testing.T) {
2722
test := testUtils.TestCase{
2823
Actions: []any{
@@ -86,8 +81,6 @@ func TestQuerySimpleWithGroupByNumberWithoutRenderedGroupField(t *testing.T) {
8681
executeTestCase(t, test)
8782
}
8883

89-
// Companion to the above using a String grouped-by field (matching the genre field in the
90-
// original issue report), ensuring the fix is not specific to a single field kind.
9184
func TestQuerySimpleWithGroupByStringWithoutRenderedGroupField(t *testing.T) {
9285
test := testUtils.TestCase{
9386
Actions: []any{

0 commit comments

Comments
 (0)