Try and rework `module.Instance.Reset` to return potential errors

[AndrewSisley]

This might require changing enumerable.Enumerable, and that brings in a host of other considerations into scope, so be careful - it might be that the current workaround is the most sensible long term solution.

Consider adding the linked documentation #161 (comment) if committing changes in this area.

[edjroz]

🤔 Been thinking about this one, I think there might be a couple of path's:

• Do nothing: Accept the deferred resetErr (a failed re-instantiation is stashed and surfaced on the next Alloc/Transform rather than returned from Reset).
• Lens local error capture: Keep Reset() signatures, but expose the stashed error through a lens-owned accessor (e.g. Instance.ResetErr() error, or a small lens-internal Resettable interface with Reset() error used only inside host-go, while still satisfying enumerable.Enumerable via a func() { _ = x.reset() } adapter at the boundary). Errors become inspectable at the reset site without touching immutable. Cost: a parallel reset path; some awkwardness at the adapter seam.
• Interface Lift , enumerable.Enumerable.Reset() error . Clean end-to-end propagation. But I'm guessing there's external breaking change, multi-repo coordination, release sequencing.

If this isn't a pressing matter I'd just document the workaround and work towards the interface lift since it's the cleanest way to handle it from the primitive.

[AndrewSisley]

If this isn't a pressing matter

Not a pressing matter, and the team is pushing quite hard at the moment for an impending v1 release - thanks to your workaround this ticket is more a long-term health issue than can be solved at slower pace.

My preference is definately your third suggestion (interface lift) but I haven't checked the impact on other areas yet, might be a bit of defer annoyance where returned Reset errors need to be handled, but hopefully that is it.

[edjroz]

If you can point me, I can check some of the blast radius on other projects, I can probably check DefraDB, but not sure if this would affect other stuff outside of my visibility.