Skip to content

Commit c6a7c7b

Browse files
authored
Merge pull request #34 from sourcerer-io/develop
fix: Correct processing of embedded image type. (#33)
2 parents 84954d4 + ce4147b commit c6a7c7b

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

fame/avatar.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,17 @@ def _embed_face(self):
146146
Browsers don't display referenced images in <img>.
147147
"""
148148
face_url = self.face_image.get('{http://www.w3.org/1999/xlink}href')
149-
BASE64_HEADER = 'data:image/jpeg;base64,'
150-
if face_url.startswith(BASE64_HEADER):
149+
if face_url.startswith('data:image/'):
151150
return
152151
if not face_url.startswith('http'):
153152
# Relative path.
154153
face_url = 'https://sourcerer.io' + face_url
155154

156-
data = urlopen(face_url).read()
155+
response = urlopen(face_url)
156+
content_type = response.headers.get_content_type()
157+
data = response.read()
157158
encoded = base64.b64encode(data).decode()
158-
data_url = BASE64_HEADER + encoded
159+
data_url = 'data:%s;base64,%s' % (content_type, encoded)
159160
self.face_image.set('{http://www.w3.org/1999/xlink}href', data_url)
160161
print('i Embedded JPEG %s' % face_url)
161162

fame/glory.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ def _get_sourcerer_mapping_url(self, github_usernames):
164164
self.sourcerer_api_origin, ','.join(github_usernames))
165165

166166
def _get_sourcerer_avatar_url(self, sourcerer_username):
167-
return '%s/assets/avatar/%s' % (self.sourcerer_origin, sourcerer_username)
167+
return '%s/assets/avatar/%s' % (self.sourcerer_origin,
168+
sourcerer_username)
168169

169170
def _save_svg(self, num, svg):
170171
image_path = self._get_image_file_path(num, temp=True)

0 commit comments

Comments
 (0)