pandas is mutable

[Karim-53]

Checklist

• I think this refactoring is useful for everyone (if it's too specific, consider a custom rule)
• I have checked there are no similar issues suggesting the same thing. This is not Replace mutable default arguments doesn't respect type annotations #318

Description

the default value of a parameter should be mutable like {}, [], or pd.DataFrame()

Pycharm is used to detect mutable objects but it doesn't work for pandas

Code Before

def f(df=pd.DataFrame()):
    pass

Code After

def f(df=None):
    if df is None:
        df=pd.DataFrame()

[reka]

@Karim-53 Thanks, that's a good point. 👍

Generally, the default Sourcery rules recognize Python's builtin data structures, but don't know too much about 3rd party packages, like pandas.

This sounds like a good candidate for an optional rule.
You can open a PR for it in the https://github.com/sourcery-ai/sourcery-rules repo.
Otherwise, we'll add this to our backlog and open a PR for it.

[Karim-53]

Hi,
Sorry, I will not have the time. I also don't know how to add a rule.
Plz feel free to add it