Skip to content

Code reviews are way too verbose #456

Open
@deboer-tim

Description

@deboer-tim

Checklist

  • This is a new feature, not a refactoring suggestion
  • I have checked for this feature in the Sourcery documentation
  • I have checked there are no open requests referencing the same feature

Description

Hey @sourcery-ai - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Notice all the boilerplate? Find it hard to scan to this comment? We have had to turn off most features of Sourcery and it is still by far the most chatty member of our team. It's like having a new hire that rarely has useful information but feels compelled to comment on everything, in depth.
  • As a result, our team response is mixed: some developers want to keep it on because sometimes there's a useful nugget. Others want to disable sourcery completely because it gets in the way of productive work and they have already tuned it out.

Net:

  • I'd really appreciate some options to drastically reduce the verboseness: removing all boilerplate text from the comments and making all messages more succinct.
  • Options to only comment above a 'threshold of certainty' would also be helpful - i.e. only add a comment when it is more sure that it's actually useful.

Here's what I looked at during the review
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions