Skip to content

Commit bffdf5a

Browse files
authored
TCS-1286 RN 0.73 Upgrade (#75)
* TCS-1286 docs: update contributing doc to reflect use of npm instead of yarn * TCS-1286 build: switch example app to use npm * TCS-1286 build: add xcode env to gitignore * TCS-1286 build: upgrade RN from 0.72 to 0.73 * TCS-1286 build: use new rn babel package * TCS-1286 build: lock RN to 0.73.1
1 parent 18499b5 commit bffdf5a

File tree

7 files changed

+20904
-7818
lines changed

7 files changed

+20904
-7818
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ DerivedData
2828
*.ipa
2929
*.xcuserstate
3030
project.xcworkspace
31+
example/ios/.xcode.env.local
3132

3233
# Android/IJ
3334
#

CONTRIBUTING.md

+17-21
Original file line numberDiff line numberDiff line change
@@ -4,51 +4,47 @@ We want this community to be friendly and respectful to each other. Please follo
44

55
## Development workflow
66

7-
To get started with the project, run `yarn` in the root directory to install the required dependencies for each package:
7+
To get started with the project, run `npm install` in the root directory to install the required dependencies for each package:
88

99
```sh
10-
yarn
10+
npm install
1111
```
1212

13-
> While it's possible to use [`npm`](https://github.com/npm/cli), the tooling is built around [`yarn`](https://classic.yarnpkg.com/), so you'll have an easier time if you use `yarn` for development.
14-
15-
While developing, you can run the [example app](/example/) to test your changes. Any changes you make in your library's JavaScript code will be reflected in the example app without a rebuild. If you change any native code, then you'll need to rebuild the example app.
16-
1713
To start the packager:
1814

1915
```sh
20-
yarn example start
16+
npm run example:start
2117
```
2218

2319
To run the example app on Android:
2420

2521
```sh
26-
yarn example android
22+
npm run example:android
2723
```
2824

2925
To run the example app on iOS:
3026

3127
```sh
32-
yarn example ios
28+
npm run example:ios
3329
```
3430

3531
Make sure your code passes TypeScript and ESLint. Run the following to verify:
3632

3733
```sh
38-
yarn typescript
39-
yarn lint
34+
npm run typescript
35+
npm run lint
4036
```
4137

4238
To fix formatting errors, run the following:
4339

4440
```sh
45-
yarn lint --fix
41+
npm run lint --fix
4642
```
4743

4844
Remember to add tests for your change if possible. Run the unit tests by:
4945

5046
```sh
51-
yarn test
47+
npm run test
5248
```
5349

5450
To edit the Objective-C files, open `example/ios/IdscanSdkExample.xcworkspace` in XCode and find the source files at `Pods > Development Pods > react-native-idscan-sdk`.
@@ -83,20 +79,20 @@ We use [release-it](https://github.com/release-it/release-it) to make it easier
8379
To publish new versions, run the following:
8480

8581
```sh
86-
yarn release
82+
npm run release
8783
```
8884

8985
### Scripts
9086

9187
The `package.json` file contains various scripts for common tasks:
9288

93-
- `yarn bootstrap`: setup project by installing all dependencies and pods.
94-
- `yarn typescript`: type-check files with TypeScript.
95-
- `yarn lint`: lint files with ESLint.
96-
- `yarn test`: run unit tests with Jest.
97-
- `yarn example start`: start the Metro server for the example app.
98-
- `yarn example android`: run the example app on Android.
99-
- `yarn example ios`: run the example app on iOS.
89+
- `npm run bootstrap`: setup project by installing all dependencies and pods.
90+
- `npm run typescript`: type-check files with TypeScript.
91+
- `npm run lint`: lint files with ESLint.
92+
- `npm run test`: run unit tests with Jest.
93+
- `npm run example:start`: start the Metro server for the example app.
94+
- `npm run example:android`: run the example app on Android.
95+
- `npm run example:ios`: run the example app on iOS.
10096

10197
### Sending a pull request
10298

babel.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module.exports = {
2-
presets: ['module:metro-react-native-babel-preset'],
2+
presets: ['module:@react-native/babel-preset'],
33
};

0 commit comments

Comments
 (0)