Skip to content

Commit 51c1155

Browse files
committed
Remove failing the mapserver run when the word error appears in the logs
1 parent 9cbfe75 commit 51c1155

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

SS14.MapServer/BuildRunners/LocalBuildService.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public async Task Build(string directory, CancellationToken cancellationToken =
6969

7070
if (process.ExitCode != 0)
7171
{
72-
var exception = new BuildException($"Failed building {_configuration.MapRendererProjectName}");
72+
var exception = new BuildException($"Failed building {_configuration.MapRendererProjectName} using exit code {process.ExitCode}");
7373
ProcessLocalBuildException(logBuffer.ToString(), "build.log", exception);
7474
}
7575

@@ -114,11 +114,10 @@ await process.WaitForExitAsync(cancellationToken)
114114
}
115115

116116
var log = logBuffer.ToString();
117-
// Bandaid the fact that the map renderer doesn't return an error code when rendering fails
118117

119-
if (process.ExitCode != 0 || LogErrorRegex().IsMatch(log))
118+
if (process.ExitCode != 0)
120119
{
121-
var exception = new BuildException($"Error while running: {command} {string.Join(' ', arguments)}");
120+
var exception = new BuildException($"Error while running: {command} {string.Join(' ', arguments)} with exit code {process.ExitCode}.");
122121
ProcessLocalBuildException(log, "run.log", exception);
123122
}
124123

0 commit comments

Comments
 (0)