Commit d32b28e
authored
# Rationale for this change
This is a follow up to a recent PR,
#984. That PR
needed to turn off the default features in the `nova-snark` crate in
order to use WASM, but that introduced a performance regression in Nova
specific code since that turned `halo2curves/asm` off. This PR adds the
`halo2curves/asm` feature flag back, but under the `cpu-perf` feature
flag.
The following is an example of the `filter` benchmark query on the
Multi-A100 system using a table size of `1,000,000`.
Currently in the `main` branch, without the `halo2curves/asm` feature
flag, Nova specific code takes 531.23 ms to execute.
<img width="1866" height="511" alt="image"
src="https://github.com/user-attachments/assets/d2d9957c-cc02-4040-b5c8-cacde6ba21c4"
/>
This PR, with the `halo2curves/asm` feature flag, Nova specific code
takes 490.04 ms to execute.
<img width="1836" height="509" alt="image"
src="https://github.com/user-attachments/assets/6318f7ee-0d85-475e-9aef-81bd1ad34cdb"
/>
# What changes are included in this PR?
- `halo2curves/asm` is added to the `cpu-pref` feature flag
- small formatting update
# Are these changes tested?
Yes, but not with WASM.
1 parent dc18e4f commit d32b28e
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
0 commit comments