Skip to content

Commit e2292b0

Browse files
committed
fix: address issues
- add to docs for plan name skipping with respect to what is returned - fix typo in Doc - replace `mulmod` with `mul` in `make_transcript`
1 parent 42ba572 commit e2292b0

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

solidity/src/proof_exprs/ProofExpr.pre.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ library ProofExpr {
3131
/// length equal to the columns in the expression
3232
/// ##### Return Values
3333
/// * `expr_ptr_out` - pointer to the remaining expression after consuming the proof expression
34-
/// * `eval` - the evaluation of the result of this expression. Cirically, this resulting evaluation must be guarenteed to be
34+
/// * `eval` - the evaluation of the result of this expression. Critically, this resulting evaluation must be guarenteed to be
3535
/// the correct evaluation of a column with the same length as the columns in the expression. Every column has implicit infinite length
3636
/// but is padded with zeros. This is guarenteed to match the length of the chi column, and varients must be designed to handle this.
3737
/// ##### Proof Plan Encoding

solidity/src/verifier/PlanUtil.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ library PlanUtil {
2525
/// @dev * length of output column name (uint64)
2626
/// @dev * output column name (variable length)
2727
/// @param __plan The calldata pointer to the plan.
28-
/// @return __planOut The updated pointer after skipping names.
28+
/// @return __planOut The updated pointer after skipping names which points to the actual plan itself. i.e., the AST without any names.
2929
function __skipPlanNames(bytes calldata __plan) external pure returns (bytes calldata __planOut) {
3030
assembly {
3131
function skip_plan_names(plan_ptr) -> plan_ptr_out {

solidity/src/verifier/Verifier.pre.sol

+1-1
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ library Verifier {
454454
append_array(transcript_ptr, table_lengths_ptr)
455455

456456
let commitment_len := mload(commitments_ptr)
457-
mstore(commitments_ptr, mulmod(commitment_len, 2, MODULUS))
457+
mstore(commitments_ptr, mul(commitment_len, 2))
458458
append_array(transcript_ptr, commitments_ptr)
459459
mstore(commitments_ptr, commitment_len)
460460

solidity/test/verifier/Verifier.t.pre.sol

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ pragma solidity ^0.8.28;
44

55
import {Test} from "forge-std/Test.sol";
66
import "../../src/base/Constants.sol";
7-
import {Errors} from "../../src/base/Errors.sol";
87
import {Verifier} from "../../src/verifier/Verifier.pre.sol";
98

109
contract VerifierTest is Test {

0 commit comments

Comments
 (0)