Fix nil pointer runtime error, adds more tests

Author: gidsi

spaceapi_validator.go

@@ -36,7 +36,10 @@ func Validate(document string) (ValidationResult, error) {
 	documentLoader := gojsonschema.NewStringLoader(document)
 
 	suppliedVersion := spaceAPIVersion{}
-	json.Unmarshal([]byte(document), &suppliedVersion)
+	err := json.Unmarshal([]byte(document), &suppliedVersion)
+	if err != nil {
+		return myResult, err
+	}
 
 	schemaString, ok := SpaceAPISchemas[strings.Replace(suppliedVersion.API, "0.", "", 1)]
 	if !ok {
@@ -45,8 +48,11 @@ func Validate(document string) (ValidationResult, error) {
 	var schema = gojsonschema.NewStringLoader(schemaString)
 
 	result, err := gojsonschema.Validate(schema, documentLoader)
+	if err != nil {
+		return myResult, err
+	}
 
-	var myErrors = []ResultError{}
+	var myErrors []ResultError
 	for _, bar := range result.Errors() {
 		myErrors = append(myErrors, ResultError{
 			bar.Field(),

spaceapi_validator_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 )
 
+var wrongVersion = `{ "api": "0.5" }`
 var invalid13 = `{ "api": "0.13" }`
 var valid13 = `{ "api": "0.13", "open": true, "space": "example", "url": "https://example.com", "logo": "https://example.com/logo.png", "location": { "lon": 42, "lat": 23 }, "state": { "open": true }, "contact": {}, "issue_report_channels": [ "email" ] }`
 
@@ -26,4 +27,14 @@ func TestValidate(t *testing.T) {
 	if len(validErrors) != 0 {
 		t.Error("Schema should have got no errors, got", len(validErrors))
 	}
+
+	validResult, err := Validate("")
+	if err == nil {
+		t.Error("Should provide an error on faulty json")
+	}
+
+	invalidResult, _ = Validate(wrongVersion)
+	if invalidResult.Valid == true {
+		t.Error("Expected validation to be false, got", invalidResult.Valid)
+	}
 }