.

Author: spacemanspiff2007

src/pyartnet/base/seq_counter.py

@@ -4,9 +4,11 @@
 class SequenceCounter:
     __slots__ = ('_ctr', '_start', '_upper')
 
-    def __init__(self, start: int = 0, upper: int = 255):
+    def __init__(self, start: int = 0, upper: int = 255) -> None:
+        if start > upper:
+            raise ValueError()
+
         self._ctr: int = start
-        assert start <= upper
         self._start: Final = start
         self._upper: Final = upper
 

src/pyartnet/impl_sacn/node.py

@@ -70,6 +70,8 @@ def __init__(self, ip: str, port: int, *,
         self._packet_base: bytearray = packet
 
         self._synchronization_address : int = 0
+
+        # See spec 6.3.2 E1.31 Synchronization Packet: Sequence Number
         self._sync_sequence_number: Final = SequenceCounter()
 
 

src/pyartnet/py.typed

@@ -1,20 +1,15 @@
 from pyartnet.base.seq_counter import SequenceCounter
 
 
-def test_seq():
-    s = SequenceCounter()
-    assert s.value == 0
-    assert s.value == 1
-    assert s.value == 2
+def test_seq() -> None:
 
-    s._ctr = 254
-    assert s.value == 254
-    assert s.value == 255
-    assert s.value == 0
-    assert s.value == 1
+    s = SequenceCounter()
+    for _ in range(10):
+        for i in range(256):
+            assert s.value == i
 
 
-def test_seq_artnet():
+def test_seq_artnet() -> None:
     s = SequenceCounter(1)
     assert s.value == 1
     assert s.value == 2
@@ -25,14 +20,14 @@ def test_seq_artnet():
     assert s.value == 1
 
 
-def test_seq_const():
+def test_seq_const() -> None:
     s = SequenceCounter(0, 0)
     assert s.value == 0
     assert s.value == 0
     assert s.value == 0
 
 
-def test_repr():
+def test_repr() -> None:
     s = SequenceCounter()
     assert repr(s) == '<SequenceCounter 0>'
     assert repr(s) == '<SequenceCounter 0>'