.

Author: spacemanspiff2007

src/pyartnet/base/base_node.py

@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 from asyncio import sleep
-from socket import socket
 from time import monotonic
 from typing import TYPE_CHECKING, Final, Generic, TypeVar
 
@@ -13,6 +12,7 @@
 
 
 if TYPE_CHECKING:
+    from socket import socket
     from types import TracebackType
 
     import pyartnet
@@ -78,7 +78,7 @@ def _send_data(self, data: bytearray | bytes, dst: tuple[str, int] | str | None
             msg = 'Socket closed! Did you forget to use "async with"?'
             raise RuntimeError(msg)
 
-        sock.sendto(self._packet_base + data, dst)
+        sock.sendto(self._packet_base + data, dst)  #type: ignore[arg-type]
         return None
 
     async def _process_values_task(self) -> None:

src/pyartnet/base/network.py

@@ -6,10 +6,10 @@
 from socket import AF_INET, AF_INET6, AF_UNSPEC, SOCK_DGRAM
 from typing import Final, Literal
 
-from typing_extensions import Self, override
+from typing_extensions import Self, TypeAlias, override
 
 
-RESOLVE_TO_IP_TYPE: Final = Literal['auto', 'v4', 'v6']
+RESOLVE_TO_IP_TYPE: TypeAlias  = Literal['auto', 'v4', 'v6']
 
 
 def validate_port(port: int, *, allow_0: bool = False) -> int:

src/pyartnet/impl_artnet/node.py

@@ -26,7 +26,7 @@ class ArtNetNode(BaseNode['pyartnet.impl_artnet.ArtNetUniverse']):
     def __init__(self, network: UnicastNetworkTarget, *,
                  name: str | None = None,
                  max_fps: int = 25,
-                 refresh_every: float = 2, start_refresh_task: bool = True,
+                 refresh_every: float = 2,
 
                  # ArtNet specific fields
                  sequence_counter: bool = True

src/pyartnet/impl_kinet/node.py

@@ -26,7 +26,7 @@ class KiNetNode(BaseNode['pyartnet.impl_kinet.KiNetUniverse']):
     def __init__(self, network: UnicastNetworkTarget, *,
                  name: str | None = None,
                  max_fps: int = 25,
-                 refresh_every: float = 2, start_refresh_task: bool = True) -> None:
+                 refresh_every: float = 2) -> None:
         super().__init__(network, name=name, max_fps=max_fps, refresh_every=refresh_every)
 
         self._dst: Final = network.dst

src/pyartnet/impl_sacn/node.py

@@ -41,7 +41,7 @@ class SacnNode(BaseNode['pyartnet.impl_sacn.SacnUniverse']):
     def __init__(self, network: UnicastNetworkTarget | MulticastNetworkTarget, *,
                  name: str | None = None,
                  max_fps: int = 25,
-                 refresh_every: float = 2, start_refresh_task: bool = True,
+                 refresh_every: float = 2,
 
                  # sACN E1.31 specific fields
                  cid: bytes | None = None, source_name: str | None = None

tests/test_impl/test_sacn.py

@@ -14,7 +14,6 @@ async def test_sacn() -> None:
         UnicastNetworkTestingTarget(('ip', 9999999)),
         cid=b'\x41\x68\xf5\x2b\x1a\x7b\x2d\xe1\x17\x12\xe9\xee\x38\x3d\x22\x58',
         source_name='default source name',
-        start_refresh_task=True
     )
     async with sacn:
 
@@ -48,7 +47,6 @@ async def test_sacn_with_sync(caplog, multicast) -> None:
         network,
         cid=b'\x41\x68\xf5\x2b\x1a\x7b\x2d\xe1\x17\x12\xe9\xee\x38\x3d\x22\x58',
         source_name='default source name',
-        start_refresh_task=False,
         name='device1'
     )
     async with sacn: