Skip to content

Commit 86dad39

Browse files
Ccd 1066 residfringe (#846)
Changes * Add spec for new reftype residfringe * rename reftype from residfringe to fringefreq * Add basic tpn * Update changelog, model name, and unrelated test
1 parent a7eb1dc commit 86dad39

5 files changed

Lines changed: 60 additions & 1 deletion

File tree

CHANGES.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
- Add new reftype fringefreq [#846]
2+
13
11.4.3 (2021-09-30)
24
===================
35

crds/jwst/specs/combined_specs.json

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,6 +1135,32 @@
11351135
"tpn":"miri_fringe.tpn",
11361136
"unique_rowkeys":null
11371137
},
1138+
"fringefreq":{
1139+
"derived_from":"Initial spec CRDS-496",
1140+
"extra_keys":null,
1141+
"file_ext":".fits",
1142+
"filekind":"fringefreq",
1143+
"filetype":"FRINGEFREQ",
1144+
"instrument":"MIRI",
1145+
"ld_tpn":"miri_fringefreq_ld.tpn",
1146+
"mapping":"REFERENCE",
1147+
"name":"miri_fringefreq.rmap",
1148+
"observatory":"JWST",
1149+
"parkey":[
1150+
[
1151+
"META.INSTRUMENT.DETECTOR"
1152+
],
1153+
[
1154+
"META.OBSERVATION.DATE",
1155+
"META.OBSERVATION.TIME"
1156+
]
1157+
],
1158+
"sha1sum":"db0a80ee8aba8cddd9dae9e7871073e2bb7ec354",
1159+
"suffix":"fringefreq",
1160+
"text_descr":"Residual Fringe",
1161+
"tpn":"miri_fringefreq.tpn",
1162+
"unique_rowkeys":null
1163+
},
11381164
"gain":{
11391165
"derived_from":"cloning tool 0.05b (2013-04-12) used on 2013-10-04",
11401166
"extra_keys":null,
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
header = {
2+
'derived_from' : 'Initial spec CRDS-496',
3+
'file_ext' : '.fits',
4+
'filekind' : 'fringefreq',
5+
'filetype' : 'FRINGEFREQ',
6+
'instrument' : 'MIRI',
7+
'mapping' : 'REFERENCE',
8+
'name' : 'miri_fringefreq.rmap',
9+
'observatory' : 'JWST',
10+
'parkey' : (('META.INSTRUMENT.DETECTOR',), ('META.OBSERVATION.DATE', 'META.OBSERVATION.TIME')),
11+
'sha1sum' : 'db0a80ee8aba8cddd9dae9e7871073e2bb7ec354',
12+
'suffix' : 'fringefreq',
13+
'text_descr' : 'Residual Fringe',
14+
}
15+
16+
comment = """
17+
The MRS residual fringe reference files contain tables of the
18+
wavelength-dependent allowable frequencies, amplitudes, SNR, and other
19+
parameters to use when applying the MRS residual fringe correction step. They
20+
are split into FITS format reference files for each of the two MIRI MRS
21+
detectors, each of which contains an extension pertaining to the SHORT, MEDIUM,
22+
and LONG grating settings (RFC_FREQ_SHORT, RFC_FREQ_MEDIUM, RFC_FREQ_LONG) and
23+
the maximum allowable amplitudes (MAX_AMP).
24+
25+
Originally requested and discussed in JIRA CRDS-496
26+
"""
27+
28+
selector = Match({
29+
})

crds/jwst/tpns/miri_fringefreq.tpn

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Commented out until INS is ready for strict model type validation:
2+
# META.MODEL_TYPE H S R FringeFreqModel

crds/tests/test_bestrefs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ def get_10_days_ago(self):
432432
return now.isoformat().split("T")[0]
433433

434434
def test_bestrefs_affected_datasets(self):
435-
self.run_script(f"crds.bestrefs --affected-datasets --old-context hst_0543.pmap --new-context hst_0544.pmap "
435+
self.run_script(f"crds.bestrefs --affected-datasets --old-context hst_0943.pmap --new-context hst_0947.pmap "
436436
f"--datasets-since {self.get_10_days_ago()}",
437437
expected_errs=0)
438438

0 commit comments

Comments
 (0)