Skip to content

Commit cf7a56c

Browse files
authored
CCD-1083 trim translations to be specific to roman (#854)
* CCD-1083 trim translations to be specific to roman NOTE: This build contains a failing test cause by a known issue CCD-1092
1 parent b27a9cc commit cf7a56c

2 files changed

Lines changed: 10 additions & 24 deletions

File tree

CHANGES.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
11.5.2 (Unreleased)
2+
===================
3+
4+
Trim translations to be specific to roman [#854]
5+
16
11.5.1 (Unreleased)
27
===================
38

crds/roman/locate.py

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -405,13 +405,13 @@ def reference_keys_to_dataset_keys(rmapping, header):
405405
"ROMAN.META.INSTRUMENT.P_FILTER" : "UNDEFINED", \
406406
"ROMAN.META.INSTRUMENT.FILTER" : None, \
407407
"ROMAN.META.INSTRUMENT.P_MODULE" : "LUNAR", \
408-
"ROMAN.META.INSTRUMENT.MODULE" : None, \
408+
"ROMAN.META.INSTRUMENT.MODULE" : "LUNAR", \
409409
"ROMAN.META.SUBARRAY.P_SUBARRAY" : None, \
410410
"ROMAN.META.SUBARRAY.NAME" : "YELLOW", \
411411
"ROMAN.META.INSTRUMENT.P_GRATING" : "UNDEFINED", \
412412
"ROMAN.META.INSTRUMENT.GRATING" : "MOZZARELLA", \
413413
"ROMAN.META.EXPOSURE.PREADPATT" : "CHECKERBOARD", \
414-
"ROMAN.META.EXPOSURE.READPATT" : "CHESSBOARD"})
414+
"ROMAN.META.EXPOSURE.READPATT" : "CHECKERBOARD"})
415415
{'ROMAN.META.EXPOSURE.P_EXPTYPE': None, 'ROMAN.META.INSTRUMENT.P_BAND': 'UNDEFINED', 'ROMAN.META.INSTRUMENT.P_DETECTOR': 'RADAR', 'ROMAN.META.INSTRUMENT.P_CHANNEL': None, 'ROMAN.META.INSTRUMENT.CHANNEL': None, 'ROMAN.META.INSTRUMENT.P_FILTER': 'UNDEFINED', 'ROMAN.META.INSTRUMENT.FILTER': None, 'ROMAN.META.INSTRUMENT.P_MODULE': 'LUNAR', 'ROMAN.META.INSTRUMENT.MODULE': 'LUNAR', 'ROMAN.META.SUBARRAY.P_SUBARRAY': None, 'ROMAN.META.SUBARRAY.NAME': 'YELLOW', 'ROMAN.META.INSTRUMENT.P_GRATING': 'UNDEFINED', 'ROMAN.META.INSTRUMENT.GRATING': 'MOZZARELLA', 'ROMAN.META.EXPOSURE.PREADPATT': 'CHECKERBOARD', 'ROMAN.META.EXPOSURE.READPATT': 'CHECKERBOARD', 'ROMAN.META.INSTRUMENT.DETECTOR': 'RADAR', 'ROMAN.META.EXPOSURE.TYPE': 'UNDEFINED'}
416416
417417
==================================================
@@ -484,28 +484,9 @@ def reference_keys_to_dataset_keys(rmapping, header):
484484

485485
# Basic common pattern translations
486486
translations = {
487-
"ROMAN.META.EXPOSURE.P_EXPTYPE" : "ROMAN.META.EXPOSURE.TYPE",
488-
489-
"ROMAN.META.INSTRUMENT.P_BAND" : "ROMAN.META.INSTRUMENT.BAND",
490-
491-
"ROMAN.META.INSTRUMENT.P_DETECTOR" : "ROMAN.META.INSTRUMENT.DETECTOR",
492-
493-
"ROMAN.META.INSTRUMENT.P_CHANNEL" : "ROMAN.META.INSTRUMENT.CHANNEL",
494-
495-
"ROMAN.META.INSTRUMENT.P_FILTER" : "ROMAN.META.INSTRUMENT.FILTER",
496-
497-
"ROMAN.META.INSTRUMENT.P_MODULE" : "ROMAN.META.INSTRUMENT.MODULE",
498-
499-
"ROMAN.META.SUBARRAY.P_SUBARRAY" : "ROMAN.META.SUBARRAY.NAME",
500-
501-
"ROMAN.META.INSTRUMENT.P_GRATING" : "ROMAN.META.INSTRUMENT.GRATING",
502-
503-
"ROMAN.META.EXPOSURE.PREADPATT" : "ROMAN.META.EXPOSURE.READPATT",
504-
"ROMAN.META.EXPOSURE.P_READPATT" : "ROMAN.META.EXPOSURE.READPATT",
505-
506-
# vvvv Speculative, not currently defined or required by CAL vvvvv
507-
"ROMAN.META.INSTRUMENT.PCORONAGRAPH" : "ROMAN.META.INSTRUMENT.CORONAGRAPH",
508-
}
487+
"ROMAN.META.EXPOSURE.P_EXPTYPE" : "ROMAN.META.EXPOSURE.TYPE",
488+
"ROMAN.META.INSTRUMENT.P_DETECTOR" : "ROMAN.META.INSTRUMENT.DETECTOR",
489+
}
509490

510491
# Rmap header reference_to_dataset field tranlations, can override basic!
511492
try:

0 commit comments

Comments
 (0)