JP-4127: Improve association generator runtime (#10384)

Co-authored-by: Tyler Pauly <tapastro@gmail.com>

Author: emolter

changes/10384.associations.rst

@@ -0,0 +1 @@
+Bypass unnecessary compare_asns calls to improve generator runtime. Factor-of-3 runtime improvement is realized for one large NRC_WFSS pool tested

jwst/associations/generator/generate.py

@@ -215,12 +215,16 @@ def match_item(item, associations):
                 List of process events.
     """
     item_associations = []
+    seen_ids = set()
     process_list = []
     for asn in associations:
-        if asn in item_associations:
+        # Can't use just `if asn in item_associations` because this triggers compare_asns call
+        # and is slow.
+        if id(asn) in seen_ids:
             continue
         matches, reprocess = asn.add(item)
         process_list.extend(reprocess)
         if matches:
             item_associations.append(asn)
+            seen_ids.add(id(asn))
     return item_associations, process_list

jwst/associations/lib/dms_base.py

@@ -392,6 +392,18 @@ def from_items(self):
             items = []
         return items
 
+    @property
+    def item_ids(self):
+        """
+        Set of all item IDs in all products of this association.
+
+        Returns
+        -------
+        set
+            Set of item IDs.
+        """
+        return {item["filename"] for item in self.from_items}
+
     @property
     def member_ids(self):
         """
@@ -497,7 +509,7 @@ def is_item_member(self, item):
         bool
             True if item is a member.
         """
-        return item in self.from_items
+        return item["filename"] in self.item_ids
 
     def is_item_ami(self, item):
         """

jwst/associations/tests/test_dms.py

@@ -22,7 +22,7 @@ def dms_registry():
 @pytest.fixture(scope="module")
 def dms_asns(dms_registry):
     """Create basic associations"""
-    result = dms_registry.match("item")
+    result = dms_registry.match({"filename": "item.fits"})
     return result