Skip to content

Commit 90d671c

Browse files
committed
Set require_ngood to 3 for oversampling
1 parent 03cb0d2 commit 90d671c

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

jwst/adaptive_trace_model/tests/test_trace_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -382,17 +382,17 @@ def test_set_fit_kwargs_error():
382382
(
383383
"NRS_IFU",
384384
"NRS1",
385-
{"pad": 2, "trim_ends": True, "require_ngood": 8},
385+
{"pad": 2, "trim_ends": True, "require_ngood": 3},
386386
),
387387
(
388388
"NRS_SLIT",
389389
"NRS1",
390-
{"pad": 1, "trim_ends": True, "require_ngood": 8},
390+
{"pad": 1, "trim_ends": True, "require_ngood": 3},
391391
),
392392
(
393393
"MIR_MRS",
394394
"MIRIFUSHORT",
395-
{"pad": 3, "trim_ends": False, "require_ngood": 8},
395+
{"pad": 3, "trim_ends": False, "require_ngood": 3},
396396
),
397397
],
398398
)

jwst/adaptive_trace_model/trace_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1313,7 +1313,7 @@ def _set_oversample_kwargs(mode, detector):
13131313
ValueError
13141314
If the input detector is not supported.
13151315
"""
1316-
require_ngood = 8
1316+
require_ngood = 3
13171317
if detector.startswith("NRS"):
13181318
# Padding to add near point sources
13191319
if mode == "NRS_IFU":

0 commit comments

Comments
 (0)