Skip to content

Commit 0adce47

Browse files
committed
make save private, library is no longer a datamodel
1 parent 5c1147b commit 0adce47

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/stpipe/library.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ def _load_member(self, index):
568568

569569
return model
570570

571-
def save(self, path, **kwargs):
571+
def _save(self, path, **kwargs):
572572
"""
573573
.. warning:: This save is NOT used by Step/Pipeline. This is
574574
intentional as the Step/Pipeline has special requirements.

tests/test_library.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ def assign_code(model, i):
737737
codes = list(example_library.map_function(assign_code))
738738

739739
output_path = tmp_path / "tmp_output"
740-
asn_path = example_library.save(output_path)
740+
asn_path = example_library._save(output_path)
741741

742742
if as_str:
743743
dst = str(asn_path)
@@ -770,13 +770,13 @@ def test_ledger():
770770
assert len(ledger) == 0
771771

772772

773-
def test_library_is_not_a_datamodel():
773+
def test_library_datamodel_relationship():
774774
"""
775775
Smoke test to make sure the relationship between
776776
AbstractModelLibrary and AbstractDataModel doesn't
777777
change.
778778
"""
779-
assert issubclass(AbstractModelLibrary, AbstractDataModel)
779+
assert not issubclass(AbstractModelLibrary, AbstractDataModel)
780780

781781

782782
def test_library_is_not_sequence():

0 commit comments

Comments
 (0)