cc.sh: avoid eval in bell check (#11)

Signed-off-by: Harmen Stoppels <harmenstoppels@gmail.com>

Author: haampie

cc.sh

@@ -208,9 +208,11 @@ execute() {
 }
 
 # Fail with a clear message if the input contains any bell characters.
-if eval "[ \"\${*#*${lsep}}\" != \"\$*\" ]"; then
-    die "Compiler command line contains our separator ('${lsep}'). Cannot parse."
-fi
+case "$*" in
+    *"$lsep"*)
+        die "Compiler command line contains our separator ('${lsep}'). Cannot parse."
+        ;;
+esac
 
 # ensure required variables are set
 for param in $params; do

test/run.sh

@@ -363,6 +363,19 @@ test_no_wrapper_environment() {
     esac
 }
 
+test_separator_in_args() {
+    wrapper_environment
+    _out=$("$WRAPPER_DIR/cc" "hello$(printf '\a')world" 2>&1)
+    _rc=$?
+    if [ "$_rc" -eq 0 ]; then
+        fail "cc with bell char in args unexpectedly exited 0"
+    fi
+    case "$_out" in
+        *"Compiler command line contains our separator"*) ;;
+        *) fail "expected 'Compiler command line contains our separator' in: $_out" ;;
+    esac
+}
+
 test_modes() {
     wrapper_environment
 
@@ -1062,6 +1075,7 @@ hello.c')
 
 all_tests='
 test_no_wrapper_environment
+test_separator_in_args
 test_modes
 test_expected_args
 test_expected_args_with_flags