Fix benchmarks, parse bin, parse dependencies_meta, and parse quoted deps

--wip-- [skip ci]

--wip-- [skip ci]

fix bug with quoted deps in subdebs

Author: spanishpear

Cargo.lock

@@ -131,7 +131,7 @@ cargo fmt --workspace
 
 ✅ **Production Ready**
 
-- All tests passing (22/22)
+- All tests passing (23/23)
 - Zero clippy warnings
 - Zero compilation errors
 - Zero-allocation parsing pipeline

README.md

@@ -72,16 +72,16 @@ fn benchmark_fixture(
     let start = Instant::now();
     let result = parse_lockfile(&fixture);
     let duration = start.elapsed();
+    assert!(result.is_ok(), "Should parse {fixture_name} successfully");
 
     if verbose {
       println!(
-        "  Warmup {}: {:.3}ms",
+        "  Warmup {}: {:.3}ms - {} packages parsed",
         i + 1,
-        duration.as_secs_f64() * 1000.0
+        duration.as_secs_f64() * 1000.0,
+        result.unwrap().1.entries.len()
       );
     }
-
-    assert!(result.is_ok(), "Should parse {fixture_name} successfully");
   }
 
   // Measure heap usage with a single run

crates/berry-bench-bin/src/main.rs

@@ -44,15 +44,31 @@ fn benchmark_fixtures(c: &mut Criterion) {
     });
   });
 
-  // Very large fixture benchmark - disabled due to parsing issues
-  // group.bench_function("duplicate_packages", |b| {
-  //     let fixture = load_fixture("duplicate-packages.yarn.lock");
-  //     b.iter(|| {
-  //         let result = parse_lockfile(black_box(&fixture));
-  //         assert!(result.is_ok(), "Should parse duplicate packages fixture successfully");
-  //         result.unwrap().1
-  //     });
-  // });
+  // Large fixture benchmark
+  group.bench_function("duplicate_packages", |b| {
+    let fixture = load_fixture("berry.lock");
+    b.iter(|| {
+      let result = parse_lockfile(black_box(&fixture));
+      assert!(
+        result.is_ok(),
+        "Should parse duplicate packages fixture successfully"
+      );
+      result.unwrap().1
+    });
+  });
+
+  // Extra large fixture benchmark
+  group.bench_function("resolutions_patches", |b| {
+    let fixture = load_fixture("resolutions-patches.yarn.lock");
+    b.iter(|| {
+      let result = parse_lockfile(black_box(&fixture));
+      assert!(
+        result.is_ok(),
+        "Should parse resolutions patches fixture successfully"
+      );
+      result.unwrap().1
+    });
+  });
 
   group.finish();
 }
@@ -66,7 +82,8 @@ fn benchmark_parsing_speed_vs_size(c: &mut Criterion) {
     ("workspaces.yarn.lock", "small-medium"),
     ("yarn4-mixed-protocol.lock", "medium"),
     ("auxiliary-packages.yarn.lock", "large"),
-    // ("duplicate-packages.yarn.lock", "very-large"), // Disabled due to parsing issues
+    ("berry.lock", "extra-large"), // Large Berry lockfile (~112KB)
+    ("resolutions-patches.yarn.lock", "extra-extra-large"), // Very large lockfile (~2MB)
   ];
 
   for (fixture_name, size_label) in fixtures {
@@ -94,6 +111,8 @@ fn benchmark_memory_usage(c: &mut Criterion) {
     "minimal-berry.lock",
     "workspaces.yarn.lock",
     "auxiliary-packages.yarn.lock",
+    "berry.lock",
+    "resolutions-patches.yarn.lock",
   ];
 
   for fixture_name in fixtures {
@@ -157,6 +176,8 @@ fn benchmark_heap_usage(c: &mut Criterion) {
     ("minimal-berry.lock", "small"),
     ("workspaces.yarn.lock", "medium"),
     ("auxiliary-packages.yarn.lock", "large"),
+    ("berry.lock", "extra-large"),
+    ("resolutions-patches.yarn.lock", "extra-extra-large"),
   ];
 
   for (fixture_name, size_label) in fixtures {

crates/berry-bench/benches/parser_benchmarks.rs

@@ -10,5 +10,8 @@ version              = "0.1.0"
 [dependencies]
 nom = "8.0.0"
 
+[dev-dependencies]
+berry-test = { path = "../berry-test" }
+
 [lints]
 workspace = true

crates/berry-core/Cargo.toml

@@ -3,7 +3,7 @@
 #[derive(Debug, Clone, PartialEq, Eq)]
 #[allow(dead_code)]
 pub struct PeerDependencyMeta {
-  optional: bool,
+  pub optional: bool,
 }
 
 // https://github.com/yarnpkg/berry/blob/master/packages/yarnpkg-core/sources/Manifest.ts#L19
@@ -12,7 +12,7 @@ pub struct PeerDependencyMeta {
 #[derive(Debug, Clone, PartialEq, Eq)]
 #[allow(dead_code)]
 pub struct DependencyMeta {
-  built: Option<bool>,
-  optional: Option<bool>,
-  unplugged: Option<bool>,
+  pub built: Option<bool>,
+  pub optional: Option<bool>,
+  pub unplugged: Option<bool>,
 }

crates/berry-core/src/metadata.rs

@@ -83,27 +83,27 @@ pub struct Package {
   pub checksum: Option<String>,
 
   /// A set of constraints indicating whether the package supports the host environments
-  conditions: Option<String>,
+  pub conditions: Option<String>,
 
   /// A map of the package's dependencies. There's no distinction between prod
   /// dependencies and dev dependencies, because those have already been merged
   /// during the resolution process
   pub dependencies: HashMap<Ident, Descriptor>,
 
   /// Map with additional information about direct dependencies
-  dependencies_meta: HashMap<Ident, Option<DependencyMeta>>,
+  pub dependencies_meta: HashMap<Ident, Option<DependencyMeta>>,
 
   /// Map of pacakges peer dependencies
   pub peer_dependencies: HashMap<Ident, Descriptor>,
 
   /// Map with additional information about peer dependencies
-  peer_dependencies_meta: HashMap<Ident, PeerDependencyMeta>,
+  pub peer_dependencies_meta: HashMap<Ident, PeerDependencyMeta>,
 
   /// all bin entries for the package
   ///
   /// We don't need binaries in resolution, but we do neeed them to keep `yarn run` fast
   /// else we have to parse and read all of the zipfiles
-  bin: HashMap<BinaryName, PortablePath>,
+  pub bin: HashMap<String, String>,
 }
 
 impl Package {