Fix yarn link issues with robust conflict resolution

Co-authored-by: paolomainardi <8747+paolomainardi@users.noreply.github.com>

Author: Copilot

ansible/macos/macos/base.yml

@@ -128,12 +128,69 @@
       failed_when: brew_check.rc != 0
       become: false
 
-    - name: Link required packages
+    - name: Handle yarn linking with conflict resolution
+      shell: |
+        set -euo pipefail
+        
+        # Function to check if yarn is installed via brew
+        is_yarn_installed() {
+          brew list yarn >/dev/null 2>&1
+        }
+        
+        # Function to check if yarn symlink points to brew installation
+        is_yarn_properly_linked() {
+          if [ -L "${homebrew_prefix}/bin/yarn" ]; then
+            local target=$(readlink "${homebrew_prefix}/bin/yarn")
+            # Check if target contains yarn cellar path
+            echo "$target" | grep -q "Cellar/yarn/"
+          else
+            false
+          fi
+        }
+        
+        # Function to remove orphaned yarn symlink
+        remove_orphaned_yarn_symlink() {
+          if [ -L "${homebrew_prefix}/bin/yarn" ] || [ -f "${homebrew_prefix}/bin/yarn" ]; then
+            echo "Removing orphaned yarn symlink..."
+            rm -f "${homebrew_prefix}/bin/yarn"
+          fi
+        }
+        
+        if is_yarn_installed; then
+          echo "Yarn is installed via brew"
+          if is_yarn_properly_linked; then
+            echo "Yarn is already properly linked"
+          else
+            echo "Yarn is not properly linked, attempting to fix..."
+            # Use --overwrite to handle conflicts
+            brew link --overwrite yarn
+            echo "Yarn linked successfully with --overwrite"
+          fi
+        else
+          echo "Yarn is not installed via brew"
+          # If yarn symlink exists but package is not installed, remove it
+          if [ -L "${homebrew_prefix}/bin/yarn" ] || [ -f "${homebrew_prefix}/bin/yarn" ]; then
+            echo "Found orphaned yarn symlink, removing it..."
+            remove_orphaned_yarn_symlink
+          fi
+        fi
+      args:
+        executable: /bin/bash
+      when: "'yarn' in all_linked_packages"
+      become: false
+      register: yarn_link_result
+      
+    - name: Show yarn linking result
+      debug:
+        msg: "{{ yarn_link_result.stdout_lines }}"
+      when: "'yarn' in all_linked_packages and yarn_link_result is defined"
+
+    - name: Link other required packages (non-yarn)
       community.general.homebrew:
         name: "{{ item }}"
         state: linked
-      loop: "{{ all_linked_packages }}"
-      when: all_linked_packages | length > 0
+      loop: "{{ all_linked_packages | difference(['yarn']) }}"
+      when: all_linked_packages | difference(['yarn']) | length > 0
       become: false
 
     - name: Run brew doctor