Platform/3048 add dumps bucket (#18)

* refs platform/3048: fix tags depends_on

* feat: add generated buckets output

* Update CHANGELOG.md

Co-authored-by: Andrea Panisson <andrea.panisson@sparkfabrik.com>

* Update outputs.tf

Co-authored-by: Andrea Panisson <andrea.panisson@sparkfabrik.com>

* fix

---------

Co-authored-by: Andrea Panisson <andrea.panisson@sparkfabrik.com>

Author: FabrizioCafolla

CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres
 to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+# [0.7.2] - 2024-08-07
+
+[Compare with previous version](https://github.com/sparkfabrik/terraform-google-gcp-application-bucket-creation-helper/compare/0.7.1...0.7.2)
+
+- Added an output with the list of bucket names generated by the module.
+
 # [0.7.1] - 2023-08-09
 
 [Compare with previous version](https://github.com/sparkfabrik/terraform-google-gcp-application-bucket-creation-helper/compare/0.7.0...0.7.1)

README.md

@@ -98,6 +98,7 @@ want to import existing buckets with a known name.
 | <a name="output_buckets_access_credentials"></a> [buckets\_access\_credentials](#output\_buckets\_access\_credentials) | Access credentials for the application buckets |
 | <a name="output_details_of_used_tag_keys"></a> [details\_of\_used\_tag\_keys](#output\_details\_of\_used\_tag\_keys) | Details of all the tag keys passed to this module (globals and per bucket). |
 | <a name="output_details_of_used_tag_values"></a> [details\_of\_used\_tag\_values](#output\_details\_of\_used\_tag\_values) | Details of all the tag values passed to this module (globals and per bucket). |
+| <a name="output_generated_bucket_names"></a> [generated\_bucket\_names](#output\_generated\_bucket\_names) | The list with the names of the buckets managed by this module. |
 ## Resources
 
 | Name | Type |

main.tf

@@ -77,7 +77,7 @@ locals {
       bucket_name     = local.generated_bucket_names[bucket.name]
       bucket_location = bucket.location != null ? bucket.location : local.default_region
       # If the bucket has no tags, we add the global tags, otherwise we use the bucket tags.
-      tag_list        = length(bucket.tag_list) > 0 ? bucket.tag_list : var.global_tags
+      tag_list = length(bucket.tag_list) > 0 ? bucket.tag_list : var.global_tags
     }
   ]
 
@@ -124,10 +124,11 @@ data "google_tags_tag_value" "tag_values" {
 
 # Bind tags to buckets.
 resource "google_tags_location_tag_binding" "binding" {
-  for_each  = local.map_of_buckets_to_be_tagged
-  parent    = "//storage.googleapis.com/projects/_/buckets/${each.value.bucket_name}"
-  location  = each.value.bucket_location
-  tag_value = data.google_tags_tag_value.tag_values[each.value.tag_friendly_name].id
+  for_each   = local.map_of_buckets_to_be_tagged
+  parent     = "//storage.googleapis.com/projects/_/buckets/${each.value.bucket_name}"
+  location   = each.value.bucket_location
+  tag_value  = data.google_tags_tag_value.tag_values[each.value.tag_friendly_name].id
+  depends_on = [google_storage_bucket.application, google_storage_bucket.disaster_recovery]
 }
 
 # -------------------------------

outputs.tf

@@ -20,3 +20,8 @@ output "details_of_used_tag_values" {
   description = "Details of all the tag values passed to this module (globals and per bucket)."
   value       = data.google_tags_tag_value.tag_values
 }
+
+output "generated_bucket_names" {
+  description = "The list with the names of the buckets managed by this module."
+  value       = local.generated_bucket_names
+}