Skip to content

Commit eb858c8

Browse files
Merge pull request #38 from sparkfabrik/task/service_ping_enabled
refs platform/1716: Enabled Service Ping - Email sender changed.
2 parents 1a9e104 + 0f35343 commit eb858c8

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ Then perform the following commands on the root folder:
5757
| gitlab\_enable\_omniauth | Choose whether to enable Gitlab Omniauth integration. Default to false. | `bool` | `false` | no |
5858
| gitlab\_enable\_registry | Choose whether to enable Gitlab Container registry. Default to false. | `bool` | `false` | no |
5959
| gitlab\_enable\_restore\_pv | Enable additional storage for TAR Restoration creation of any appreciable size | `bool` | `false` | no |
60+
| gitlab\_enable\_service\_ping | Enable Gitlab Service Ping | `bool` | `true` | no |
6061
| gitlab\_enable\_smtp | Setup Gitlab email address to send email. | `bool` | `false` | no |
6162
| gitlab\_gitaly\_disk\_size | Setup persistent disk size for gitaly data in GB. Default 100 GB | `number` | `100` | no |
6263
| gitlab\_gitaly\_max\_unavailable | For PodDisruptionBudget, how many pods can be unavailable at one time for Gitaly StatefulSet | `number` | `0` | no |

main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -560,6 +560,7 @@ locals {
560560
ENABLE_MIGRATIONS = var.gitab_enable_migrations
561561
ENABLE_PROM_EXPORTER = var.gitab_enable_prom_exporter
562562
GITALY_MAX_UNAVAILABLE = var.gitlab_gitaly_max_unavailable
563+
ENABLE_SERVICE_PING = var.gitlab_enable_service_ping
563564

564565
#Bucket Names
565566
ARTIFACTS_BCKT = google_storage_bucket.gitlab_bucket["artifacts"].name

values.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ global:
4848
## Rails based portions of this chart share many settings
4949
appConfig:
5050
## doc/charts/globals.md#general-application-settings
51-
enableUsagePing: false
51+
enableUsagePing: ${ENABLE_SERVICE_PING}
5252

5353
## https://docs.gitlab.com/charts/charts/globals#cron-jobs-related-settings
5454
cron_jobs: {}
@@ -118,8 +118,11 @@ global:
118118
secret: gitlab-smtp-secret
119119
key: password
120120
starttls_auto: true
121-
email:
122-
from: ${SMTP_USER}
121+
122+
## GLOBAL Outgoing email server settings
123+
email:
124+
from: ${SMTP_USER}
125+
reply_to: ${SMTP_USER}
123126

124127
## Timezone for containers.
125128
time_zone: ${TIMEZONE}

variables.tf

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -493,6 +493,12 @@ variable "gitab_enable_prom_exporter" {
493493
default = false
494494
}
495495

496+
variable "gitlab_enable_service_ping" {
497+
type = bool
498+
description = "Enable Gitlab Service Ping"
499+
default = true
500+
}
501+
496502
# Peformance optimization. Max and min pod replicas for HPA.
497503
variable "gitlab_hpa_min_replicas_registry" {
498504
type = number

0 commit comments

Comments
 (0)