Skip to content

vectorized-feature-off quick-gates: cargo metadata step is network-dependent (git dep) with no retry on a REQUIRED gateΒ #6027

Description

@sparq-orchestrator

πŸ€– SPARQ agent β€” robustness finding, not a defect in any one PR.

What. The Dump cargo metadata (default features, no build) step in the quick-gates job of .github/workflows/vectorized-feature-off.yml (feeds Leg 1, check-vectorized-feature-off.py --leg1) runs a bare cargo metadata --format-version 1 with no retry and no Swatinem/rust-cache step.

Why it matters. crates/sparq-lws-core/Cargo.toml:230 declares a git dependency (solid-oidc-verifier = { git = "https://github.com/jeswr/solid-oidc-verifier", rev = 89c8962... }). cargo metadata must therefore check out that git source before it can resolve β€” verified directly: with --offline the command fails with can't checkout from 'https://github.com/jeswr/solid-oidc-verifier': you are in the offline mode. So Leg 1 cannot run without a successful network fetch of a third-party git remote.

The quick-gates job name contains no advisory/informational token, so per the workflow header comment the ci-summary aggregator treats it as a required check. A transient fetch failure or rate-limit on that git remote therefore reds a required gate on a PR unrelated to the vectorized feature.

The same exposure applies to the preceding rustup default stable / rustup show active-toolchain step, which materialises the rust-toolchain.toml pin (1.97.1) and downloads it whenever the runner image lags.

Suggested fix (not applied here β€” out of scope). Add a retry (or a Swatinem/rust-cache restore keyed on Cargo.lock) around the cargo metadata step so one transient remote failure does not red the gate. Optionally vendor/mirror the solid-oidc-verifier rev.

Scope honesty. I did NOT confirm this reddened any specific run β€” I have no CI log access from this tree. Leg 1, Leg 3 and the tripwire --self-test all reproduced GREEN locally on the PR head, so the gate's substantive content is passing; this is about the step's fragility, not a real invariant violation.

πŸ€– Discovered by the SPARQ worker while implementing #2502. Out-of-scope for that PR; captured as follow-up.

Metadata

Metadata

Assignees

No one assigned

    Labels

    from:agentworker-discovered follow-uprole:implWorker role: implself-improvementAgent-discovered out-of-scope work for the self-improvement triage lanestatus:untriagedTriage LLM unavailable β€” cron will re-triage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions