Refactor (#2)

refactor

Author: pjdufour

.circleci/config.yml

@@ -2,61 +2,67 @@ version: 2.1
 executors:
   base:
     docker:
-      - image: circleci/golang:1.11
+      - image: circleci/golang:1.12-node
     working_directory: /go/src/github.com/spatialcurrent/go-reader-writer
 jobs:
   pre_deps_golang:
     executor: base
     steps:
       - checkout
-      - run: go get -d ./...
+      - run: make deps_go
       - run: sudo chown -R circleci /go/src
       - save_cache:
           key: v1-go-src-{{ .Branch }}-{{ .Revision }}
           paths:
             - /go/src
-  test:
+  test_go:
     executor: base
     steps:
       - run: sudo chown -R circleci /go/src
       - restore_cache:
           keys:
             - v1-go-src-{{ .Branch }}-{{ .Revision }}
-      - run:
-          name: Install gometalinter
-          command: |
-            go get -u github.com/alecthomas/gometalinter
-            gometalinter --install
-      - run:
-          name: Test
-          command: bash scripts/test.sh
-  validate:
+      - run: make deps_go_test
+      - run: make test_go
+      - run: make imports
+      - run: git diff --exit-code
+  test_javascript:
     executor: base
     steps:
       - run: sudo chown -R circleci /go/src
       - restore_cache:
           keys:
             - v1-go-src-{{ .Branch }}-{{ .Revision }}
-      - run:
-          name: Install Dig
-          command: sudo apt update && sudo apt install dnsutils
-      - run:
-          name: "Update ~/.ssh/known_hosts"
-          command: |
-            mkdir ~/.ssh/
-            touch ~/.ssh/known_hosts
-            for ip in $(dig @8.8.8.8 github.com +short); do ssh-keyscan github.com,$ip; ssh-keyscan $ip; done 2>/dev/null >> ~/.ssh/known_hosts
-      - run: go get github.com/spatialcurrent/go-header/...
-      - run: go install github.com/spatialcurrent/go-header/cmd/goheader
-      - run: goheader fix --fix-year 2019 --exit-code-on-changes 1 --verbose
+      - run: sudo npm install -g n
+      - run: sudo n v11.15.0
+      - run: sudo npm install --global source-map-support
+      - run: make deps_gopherjs
+      - run: make deps_javascript
+      #- run: npm run test:clean
+  examples:
+    executor: base
+    steps:
+      - run: sudo chown -R circleci /go/src
+      - restore_cache:
+          keys:
+            - v1-go-src-{{ .Branch }}-{{ .Revision }}
+      - run: sudo npm install -g n
+      - run: make deps_gopherjs
+      - run: make deps_javascript
+      - run: npm run build:clean
+      - run: make run_example_c
+      - run: make run_example_cpp
+      #- run: make run_example_javascript
+      - run: make run_example_python
   build_cli:
     executor: base
     steps:
       - run: sudo chown -R circleci /go/src
       - restore_cache:
           keys:
             - v1-go-src-{{ .Branch }}-{{ .Revision }}
-      - run: bash scripts/build_cli.sh
+      - run: go get github.com/inconshreveable/mousetrap # for windows CLI builds
+      - run: make build_cli
       - store_artifacts:
           path: bin
           destination: /
@@ -67,12 +73,10 @@ jobs:
       - restore_cache:
           keys:
             - v1-go-src-{{ .Branch }}-{{ .Revision }}
-      - run:
-          name: Install GopherJS
-          command: go get -u github.com/gopherjs/gopherjs
-      - run: bash scripts/build_javascript.sh
+      - run: make deps_gopherjs
+      - run: make build_javascript
       - store_artifacts:
-          path: bin
+          path: dist
           destination: /
   build_so:
     executor: base
@@ -81,18 +85,22 @@ jobs:
       - restore_cache:
           keys:
             - v1-go-src-{{ .Branch }}-{{ .Revision }}
-      - run: bash scripts/build_so.sh
+      - run: sudo make deps_arm
+      - run: make build_so
       - store_artifacts:
           path: bin
           destination: /
 workflows:
   main:
     jobs:
       - pre_deps_golang
-      - test:
+      - test_go:
+          requires:
+            - pre_deps_golang
+      - test_javascript:
           requires:
             - pre_deps_golang
-      - validate:
+      - examples:
           requires:
             - pre_deps_golang
       - build_cli:

.eslintignore

@@ -0,0 +1,10 @@
+__mocks__/
+dist/
+bin/
+node_modules/
+webpack/
+.DS_Store
+.npm
+node_modules
+npm-debug.*
+package-lock.json

.eslintrc

@@ -0,0 +1,35 @@
+{
+  "parser": "babel-eslint",
+  "extends": "eslint-config-airbnb",
+  "rules": {
+    "arrow-parens": ["error", "as-needed"],
+    "class-methods-use-this": "off",
+    "comma-dangle": ["error", { "objects": "always-multiline" }],
+    "import/no-named-as-default": "off",
+    "import/no-unresolved": "off",
+    "no-use-before-define": "off",
+    "object-curly-newline": "off",
+    "prefer-destructuring": "off",
+    "react/destructuring-assignment": "off",
+    "react/forbid-prop-types": "off",
+    "react/jsx-filename-extension": "off",
+    "react/jsx-no-bind": "off",
+    "react/no-access-state-in-setstate": "off",
+    "react/prefer-stateless-function": "off",
+    "react/require-default-props": "off",
+    "react/sort-comp": ["error", {                // Team Preference
+      "order": [
+        "static-methods",
+        "/constructor/",
+        "/state/",
+        "instance-variables",
+        "lifecycle",
+        "getters",
+        "everything-else",
+        "render"
+      ]
+    }],
+    "sort-keys": "error",
+    "space-before-function-paren": ["error", "always"]
+  }
+}

.gitignore

@@ -1,4 +1,11 @@
-secret/
-bin/
+bin
+dist
+vendor
+Gopkg.lock
 *.so
 *.h
+.DS_Store
+.npm
+node_modules
+npm-debug.*
+package-lock.json

AUTHORS

@@ -1,4 +1,4 @@
-go-reader is maintained by Spatial Current, Inc.
+go-reader-writer is maintained by Spatial Current, Inc.
 
 Authors:
 

CONTRIBUTING.md

@@ -1,8 +1,8 @@
-# Contributing to go-reader
+# Contributing to go-reader-writer
 
 ## Contributor License Agreement
 
-Thank you for your interest in contributing.  You will first need to agree to the license.  Simply post the following paragraph, with "your name" and "your github account" substituted as needed, to the first issue [#1](https://github.com/spatialcurrent/go-reader/issues/1).  Otherwise, you can email us [here](mailto:opensource@spatialcurrent.io?subject=CLA).
+Thank you for your interest in contributing.  You will first need to agree to the license.  Simply post the following paragraph, with "your name" and "your github account" substituted as needed, to the first issue [#1](https://github.com/spatialcurrent/go-reader-writer/issues/1).  Otherwise, you can email us [here](mailto:opensource@spatialcurrent.io?subject=CLA).
 
 I, **< YOUR NAME > (< YOUR GITHUB ACCOUNT >)**, agree to the license terms.  My contributions to this repo are granted to **Spatial Current, Inc.** under a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable license and/or copyright is transferred.
 
@@ -12,4 +12,4 @@ This library is still in alpha (0.x.x), so versioning is not semantic yet.
 
 ## Authors
 
-See [AUTHORS](https://github.com/spatialcurrent/go-reader/blob/master/AUTHORS) for a list of contributors.
+See [AUTHORS](https://github.com/spatialcurrent/go-reader-writer/blob/master/AUTHORS) for a list of contributors.

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 Spatial Current, Inc.
+Copyright (c) 2019 Spatial Current, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal