Fix activitylog cleanup to require integer days input

Author: sandeep728

src/CleanActivitylogCommand.php

@@ -29,6 +29,13 @@ public function handle()
         $log = $this->argument('log');
 
         $maxAgeInDays = $this->option('days') ?? config('activitylog.delete_records_older_than_days');
+        if (filter_var($maxAgeInDays, FILTER_VALIDATE_INT) === false) {
+            $this->error('The days option must be an integer.');
+
+            return 1;
+        }
+
+        $maxAgeInDays = (int) $maxAgeInDays;
 
         $cutOffDate = Carbon::now()->subDays($maxAgeInDays)->format('Y-m-d H:i:s');
 

tests/CleanActivitylogCommandTest.php

@@ -46,3 +46,47 @@
 
     expect(Activity::where('created_at', '<', $cutOffDate)->get())->toHaveCount(0);
 });
+
+it('does not clean the activity log when days config value is invalid', function (mixed $days) {
+    app()['config']->set('activitylog.delete_records_older_than_days', $days);
+
+    collect(range(1, 60))->each(function (int $index) {
+        Activity::create([
+            'description' => "item {$index}",
+            'created_at' => Carbon::now()->subDays($index)->startOfDay(),
+        ]);
+    });
+
+    expect(Activity::all())->toHaveCount(60);
+
+    $exitCode = Artisan::call('activitylog:clean');
+
+    expect($exitCode)->toBe(1);
+    expect(Activity::all())->toHaveCount(60);
+})->with([
+    false,
+    'abc',
+    '7.5',
+    '',
+]);
+
+it('does not clean the activity log when days option value is invalid', function (mixed $days) {
+    collect(range(1, 60))->each(function (int $index) {
+        Activity::create([
+            'description' => "item {$index}",
+            'created_at' => Carbon::now()->subDays($index)->startOfDay(),
+        ]);
+    });
+
+    expect(Activity::all())->toHaveCount(60);
+
+    $exitCode = Artisan::call('activitylog:clean', ['--days' => $days]);
+
+    expect($exitCode)->toBe(1);
+    expect(Activity::all())->toHaveCount(60);
+})->with([
+    false,
+    'abc',
+    '7.5',
+    '',
+]);