fix: duration should be parsed as float (#3869)

* Fix duration should be float

Updated video frame extraction logic and supported formats.

* Fix frame extraction logic in Video.php

Updated the logic to extract video frames by clamping the seconds to the video duration and using the correct variable for frame extraction.

* Remove unsupported video formats and mime types

Removed unsupported video formats from the list.

* Remove 'mp4v-es' from video format lists

Removed 'mp4v-es' from supported video formats.

* Add support for 'video/mpeg' format

Author: francoism90

src/Conversions/ImageGenerators/Video.php

@@ -6,12 +6,14 @@
 use FFMpeg\FFMpeg;
 use FFMpeg\Media\Video as FFMpegVideo;
 use Illuminate\Support\Collection;
+use Illuminate\Support\Number;
 use Spatie\MediaLibrary\Conversions\Conversion;
 
 class Video extends ImageGenerator
 {
     public function convert(string $file, ?Conversion $conversion = null): ?string
     {
+        // Create an FFMpeg instance
         $ffmpeg = FFMpeg::create([
             'ffmpeg.binaries' => config('media-library.ffmpeg_path'),
             'ffprobe.binaries' => config('media-library.ffprobe_path'),
@@ -25,13 +27,19 @@ public function convert(string $file, ?Conversion $conversion = null): ?string
             return null;
         }
 
-        $duration = $ffmpeg->getFFProbe()->format($file)->get('duration');
+        // Get the duration of the video in seconds
+        $duration = (float) $ffmpeg->getFFProbe()->format($file)->get('duration');
 
+        // Determine at which second to extract the frame
         $seconds = $conversion ? $conversion->getExtractVideoFrameAtSecond() : 0;
-        $seconds = $duration <= $seconds ? 0 : $seconds;
 
+        // Clamp the seconds to be within the video duration
+        $seconds = Number::clamp($seconds, 0, $duration);
+
+        // Define the output image file path
         $imageFile = pathinfo($file, PATHINFO_DIRNAME).'/'.pathinfo($file, PATHINFO_FILENAME).'.jpg';
 
+        // Extract the frame at the specified time and save it as an image
         $frame = $video->frame(TimeCode::fromSeconds($seconds));
         $frame->save($imageFile);