Merge pull request #2840 from JHWelch/remove-unnecessary-call

drbyte · web-flow · commit 3c05f04d1227 · 2025-05-13T23:32:23.000-04:00
Remove `collectPermissions` that is not being assigned
diff --git a/src/Traits/HasPermissions.php b/src/Traits/HasPermissions.php
@@ -450,7 +450,6 @@ public function forgetWildcardPermissionIndex(): void
     public function syncPermissions(...$permissions)
     {
         if ($this->getModel()->exists) {
-            $this->collectPermissions($permissions);
             $this->permissions()->detach();
             $this->setRelation('permissions', collect());
         }

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,6 @@ public function forgetWildcardPermissionIndex(): void`
`450`	`450`	`public function syncPermissions(...$permissions)`
`451`	`451`	`{`
`452`	`452`	`if ($this->getModel()->exists) {`
`453`		`- $this->collectPermissions($permissions);`
`454`	`453`	`$this->permissions()->detach();`
`455`	`454`	`$this->setRelation('permissions', collect());`
`456`	`455`	`}`